GithubHelp home page GithubHelp logo

Comments (8)

dead-horse avatar dead-horse commented on May 3, 2024 1

1941812

from bodyparser.

dead-horse avatar dead-horse commented on May 3, 2024

https://github.com/cojs/co-body/blob/master/lib/json.js#L36

error is thrown here, you can add this in your custom error handler:

try {
   yield bodyParser({
      formLimit: '200kb',
      jsonLimit: '1mb',
    }).call(this,next)
} catch (err) {}

from bodyparser.

eisneim avatar eisneim commented on May 3, 2024

stupid me!! just after i post the issue , i realized i can do it in that way! thanks anyway

from bodyparser.

eisneim avatar eisneim commented on May 3, 2024

this method will also have a problem, it will caught not only the JSON parse error but all the nested middleware's error and router's error , which means, app.on('error') will become useless.

how to make this better?

from bodyparser.

dead-horse avatar dead-horse commented on May 3, 2024

maybe we can add options.onerror for koa-bodyparser to support custom error handler?

from bodyparser.

eisneim avatar eisneim commented on May 3, 2024

it would be great ! my current solution is:
add global error handler and check error type

if((err instanceof SyntaxError) && err.body ){
    error = {
        msg:'JSON对象语法错误,请检查',
        detail: err.toString(),
    }
}

from bodyparser.

dead-horse avatar dead-horse commented on May 3, 2024

koa-bodyparser@1.6.0

from bodyparser.

eisneim avatar eisneim commented on May 3, 2024

pretty efficient!

from bodyparser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.