kodingdotninja / chakra-icons Goto Github PK

right now you can get output in the form of an arrow function (props) => <Icon...> or in the form of a call to createIcon({...}). However, you can't control (to my knowledge) which one you get. It would be nice to have an option or flag to force one or the other, if possible.

Thanks.

We have been add showcase web app in website directory.

I think we need to set custom command in Vercel.

• build yarn build
• and path to next in directory website

I have been set dns for domain https://chakra-icons to vercel dns

Thanks

Hi! Great project, but I have trouble converting some files.

Minimal reproduction

CLI:

> npx create-chakra-icons -o Icons.js ./check.svg

Property value expected type of string but got null
✖  Error building interactive interface

SVG:

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 67 67">
  <g fill="none" stroke="#000">
    <path d="m18.951 33.437 9.95 9.951L48.36 23.929"/>
    <circle cx="33.5" cy="33.5" r="33.5" stroke="none"/>
    <circle cx="33.5" cy="33.5" r="33"/>
  </g>
</svg>

Env.: node v14.17.6 @ macOS 11.6

Thanks for your help!

• #429

Hello,
awesome tool, I love it! I have an issue with some SVGs though.

tl;dr Some SVG contains name space which are invalid in js/jsx
tl;dr: https://stackoverflow.com/questions/59820954/syntaxerror-unknown-namespace-tags-are-not-supported-by-default

Cheers! 🍺

Hi,
Is there an option to only add new items to the output file from create-chakra-icons not generate it from scratch every time?
I'm asking this because I have many icons and I'm wondering if I can skip commiting them in git.
If we have the option to only extend the output document, other team members will be able to add icons to the document without having the original svg of the previous icons.

New features for @chakra-icon/cli ⚙️

• snapshot.json to chakra-icons-lock.yaml
• add commit hash from icons source in chakra-icons-lock.yaml
• update script schedule (only schedule or update lockfile can be written new lockfile)

An average of loading time is 3s need to optimize this

Current issue found when the source of svgs have duplicates files.

How to fix

• see this source https://github.com/kodingdotninja/chakra-icons/blob/main/tooling/cli/src/build.ts#L88
• at this line use glob for find svg in filesystem and need to be make unique (filter by name or ideal unique by content data)

Since we've moved to Cloudflare Pages, no need to work on this and wait for #429.

Current search API for the websites uses Next.js API routes, which cannot be used if deploy statically on Render static websites. Koding Ninja has Cloudflare Workers account ready. Offloading it there or even better, not using any external APIs would be great.

First known at #24 (https://github.com/kodingdotninja/chakra-icons/runs/5040575945), chakra-icons binary via tooling/cli was not found.

After further investigation, the chakra-icons CLI is not being symlinked inside node_modules/.bin which we discovered at https://github.com/kodingdotninja/chakra-icons/runs/5042427766?check_suite_focus=true:

This is due to CLI dist file does not exist when yarn install attempts to symlink binary files, and only exist when running yarn build afterwards. Proposed solution is to stub the CLI file so that yarn install can symlink the binary and yarn build will replace it afterwards without needing to check symlinks (see #34).

• #429

when I'm trying run chore website in local I'm getting this error

There was an issue with Icon duplicate name, maybe add some filter for it?

Issue

found: https://github.com/kodingdotninja/chakra-icons/runs/8296840563

• It's break "synchronize" scheduler

I've noticed this a couple of times now running the script, and looking into why and building a reproduction I noticed that the generated Icon loses the parent fill:none property if set.

I'm no expert on SVGs so maybe our svgs shouldn't depend on top level properties, or that this is a by product of the SVGs I am grabbing from Figma.

https://codesandbox.io/p/sandbox/xg4vp2