kohlbacherlab / dnpm-dip-api-gateway

REST API Gateway component for DNPM:DIP

DNPM:DIP - REST API Gateway

REST API Gateway component to expose DNPM:DIP modules

WORK IN PROGRESS

API Docs (Preliminary):

https://github.com/KohlbacherLab/dnpm-dip-api-gateway/blob/main/app/controllers/README.md

dnpm-dip-api-gateway's Issues

Generated fake patient mtb data does not match generated JSON schema for coding

The generated fake patient mtb data does not match generated JSON schema.

Sources

Schema file and fake data are generated from example DNPM:DIP source:

• Schema: https://dnpm.bwhealthcloud.de/api/mtb/etl/patient-record/schema
• Fake Data: https://dnpm.bwhealthcloud.de/api/mtb/fake/data/patient-record

Comparison

This will compare an example part of Schema with generated mtb data.

Definitions in schema

For example, a Patient is defined as:

"patient": {
      "type": "object",
      "additionalProperties": false,
      "properties": {
...
        "gender": {
          "$ref": "#/definitions/Gender"
        },
        "birthDate": {
          "$ref": "#/definitions/YearMonth"
        },
 ...
    }

Gender is defined as:

    "Gender": {
      "type": "string",
      "enum": [
        "female",
        "male",
        "other",
        "unknown"
      ]
    },

Generated fake patient mtb data

Same part in generated fake patient mtb data does not use a string but an object:

  "patient": {
    "id": "fbd23d0b-f81b-4a2f-b53b-e93871069cfd",
    "gender": {
      "code": "male",
      "display": "Männlich",
      "system": "Gender"
    },
    "birthDate": "1977-01-01",
  ...
  }

Conclusion

The gender (and all other object values using a coding scheme) should use some kind of schema definition containing code, display and system.

MTB model contains diagnoses.code but diagnoses.icd10 in schema

The JSON schema uses diagnoses.icd10 but data model uses diagnoses.code

Sources

Schema file and fake data are generated from example DNPM:DIP source:

• Schema: https://dnpm.bwhealthcloud.de/api/mtb/etl/patient-record/schema
• Fake Data: https://dnpm.bwhealthcloud.de/api/mtb/fake/data/patient-record

Comparison

Schema says:

...
"MTBDiagnosis": {
      "type": "object",
      "additionalProperties": false,
      "properties": {
...
        "id": {
          "$ref": "#/definitions/Id"
        },
        "icd10": {                                                     <--- Here!
          "$ref": "#/definitions/Coding"
        },
...

but example fake data uses:

...
  "diagnoses": [
    {
      "id": "2b478ee3-f5c0-4429-8367-7215b1908a19",
      "patient": {
        "id": "fbd23d0b-f81b-4a2f-b53b-e93871069cfd",
        "type": "Patient"
      },
      "recordedOn": "2004-05-15",
      "code": {                                                        <---- Here!
        "code": "C76.7",
        "display": "Bösartige Neubildung: Sonstige ungenau bezeichnete Lokalisationen",
        "system": "http://fhir.de/CodeSystem/bfarm/icd-10-gm",
        "version": "2024"
      },
...