konveyor / controller

Common controller lib.

controller

Common controller lib. Provides components shared by application controllers.

Requires: Go 1.13+ and Go Modules

---

Logging

Logging can be configured using environment variables:

• LOG_DEVELOPMENT: Development mode with human readable logs and (default) verbosity=4.
• LOG_LEVEL: Set the verbosity.

Verbosity:

• Info(3) used for Info logging.
• Info(4) used for Debug logging.
• Info(5) used for Debug+ high rate events.

Package:

• filebacked:
  • Info(5): file create,delete
  • Info(6): file read,write.
• inventory:
  • container:
    • Info(3): reconciler lifecycle.
    • Error(4): channel send failed.
  • model:
    • Info(3):
      • database: lifecycle.
      • journal: journal and watch lifecycle.
      • model: insert,update,delete.
    • Info(4):
      • client: (db) transaction lifecycle;model get,list.
      • journal: event staging.
      • watch: lifecycle.
    • Info(5):
      • watch: event sent,received.
      • table: SQL statements.
  • web:
    • Info(3):
      • watch: lifecycle.
    • Info(4):
      • watch: event sent,received.
  • ref:
    • Info(3): reference mapping added,deleted.
    • Info(4): reference lookup and reconcile events queued.

---

controller's Issues

Table.Delete() needs to return NotFound.

Table.Delete() needs to return NotFound error when nothing matched (and delete).
For completeness.

OCP Reconciler not using DB transaction properly.

As of #32, The transaction must be used for write operation else a block-forever will occur because Go does not support re-entrant mutexes. The OCP Reconciler did not get refitted.

OWNERS.md Missing

OWNERS.md Missing per https://github.com/konveyor/community/blob/main/MAINTAINERS.md guidelines

Consider making releases of common controller package

We need a way for dependencies to be expressed on the controller pkg from mig-controller and virt-controller.

Right now mig-controller is importing master of this repo referring to whatever the newest commit is at the time of dep resolution, but perhaps we should consider tags or versions in this repo when it comes time to cut releases in either of the depending controllers.

Fix "database is locked" error.

The sqlite DB is locked while any Rows (cursor) is open. While iterating a cursor, an insert(), update(), delete() or Tx.Commit() will fail. Thinking we need to change the dbMutex to a RW lock and have Client.List() methods dbMutex.RLock()/RUnlock() while the cursor is open.

"msg":"commit failed.","provider":"konveyor-forklift/boston-07","error":"database is locked"

Generate events for cascading delete.

Generate events for cascading delete.
When using foreign-key constraints (on delete cascade), rows will be deleted without generating events.
The transaction needs to build a graph (following FKs) of models that will be deleted (by cascade) and generate events.