koofr / epeg Goto Github PK

Hey! I just found your repo and it seems as if you did some tremendous work to epeg. Are you interested in merging back into https://github.com/mattes/epeg?

Thanks for your work on this and https://github.com/koofr/goepeg! Incredibly fast solutions with a nice simple API.

I saw in #1 that this and the upstream diverged a bit, but one behavior that may be worth porting over is... mattes/epeg@126c514

If I compile https://github.com/mattes/epeg from source and run the binary against an image it preserves orientation, but https://github.com/koofr/epeg.git seems to miss out on that functionality.

I'm not sure how to build this fork's epeg as a standalone binary, but I can at least use the https://github.com/koofr/goepeg library with bindings to validate that it's not preserving rotation.

package main

import (
	"github.com/koofr/goepeg"
	"log"
	"os"
	"strconv"
)

func main() {
	args := os.Args[1:]

	dimension, err := strconv.Atoi(args[2])
	if err != nil {
		log.Fatal(err)
	}

	quality := 100
	if err := goepeg.Thumbnail(args[0], args[1], dimension, quality, goepeg.ScaleTypeFitMax); err != nil {
		log.Fatal(err)
	}
}

The upstream epeg preserves orientation data.

But this fork loses that unfortunately.

I'm happy to help if I can, but I imagine I don't know enough about the implementation or C in general to be of much assistance.