korekontrol / vscode-saltstack Goto Github PK

Hi is it possible to make it compatible with VS code 1.18 instead of 1.19? Or are there breaking changes?

Hi, @cbosdo and myself have hacked an experimental Language Server for SaltStack SLS during this year's hackweek at @SUSE. The project is still in a very early state (see: https://github.com/dcermak/salt-lsp) but we were wondering whether you'd be interested in collaborating in the future?

I think that it could be definitely beneficial for us to join our efforts here, resulting in less duplicated efforts. What do you all think?

This expression
{% do network2host[interfacedetails['network']].update({current_host:{'ip':interfacedetails['ip'],'mac':interfacedetails['mac']}}) %}
is wrongly recognized as a variable. Therefore the problem message:
Jinja variables should have spaces before and after: '{{ var_name }}' salt-lint(206) does not apply and should not be displayed.

network2host and current_host are dicts

Since Jinja is rendered by Salt first, I think it should be highlighted above all else even if it is inside of a string. It can be quite annoying to lose your highlighting just because your Jinja is inside a string even though the renderer does not treat it as a string.

Hi,

I'm running into an installation issue with v0.0.8 on the following vscode setup

Version: 1.54.3
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Linux x64 5.8.0-48-generic snap
Ubuntu 20.04 LTS 64-bit

The extension doesn't get loaded after installation, even after window reload and vscode restart. The issue manifests through the lack of color/syntax highlighting and no salt related auto completion suggestions when pressing ctrl+space (just the default vscode text suggestions). I first thought this might be due to conflict with Better Jinja and salt-lint extensions but still had the same issue after uninstalling them.

The workaround for now has been

1. Install extension
2. Install a lower version which enables the "Reload required" button
3. Press the "Reload required" button
4. Update to the latest version
5. Press the "Reload required" button again

This seems to load the extension properly. Perhaps there is a way to reload the extension directly through the command palette?

Either way, minor issue but thought I'd mention it.

Best regards

Open VSX is the open-source VS Code extension registry that is used by default in VSCodium. Currently the korekontrol.saltstack extension isn't available.

As a temporary solution I've openend a pull requrest to automate the release of the latest version open-vsx/publish-extensions#64.

Can I issue a few feature requests
For example, the following functional requirements

• Various completions
• Documentation lookup
• Yaml validation. Yaml validation by leverage Yaml language server.
• Code navigation by Symbols, press Ctrl + Shift + O.
• Hover over module names, to show module documentation.

Refer to the link
https://github.com/VSChina/vscode-ansible
https://plugins.jetbrains.com/plugin/7792-yaml-ansible-support

I don't think it would be too hard to add autocompletion, such that, when I type, say, file., I get a dropdown that contains exists, managed, symlink, etc. This could also be implemented as snippets instead.

It would be nice if this could lint SLS files with roaldnefs/salt-lint for you

When typing {% the auto completion seems to give me a completion of {%%}} (placing my cursor in the centre of the %'s)

Unfortunately, this is not syntactically valid Jinja2

Thanks for the great extension! I noticed a couple instances where the JINJA highlighting is wrong:

1. Commented JINJA after YAML value is not properly highlighted as comments

   {% set Stuff = "/tmp/baz.json" %}
   example:
     file.managed:
       - name: /tmp/foo.json {# {{ Stuff }} #}

2. JINJA text highlighting for this case should NOT be commented, as JINJA will render and replace the YAML '#'

   # {% set Stuff = "/tmp/baz.json" %}
   example:
     file.managed:
       - name: {{ Stuff }}