kotalco / crossover-blacklist

crossover-blacklist

crossover-blacklist's Issues

Review comments

• Remove APIKey from the Config struct
• If default black listed methods is always an empty array, remove it from the New method config{} struct, and leave the empty type default value be used.

return &Config{}

• Default blacklisted methods can be removed, because there's no list of methods that I am ware of is shared between protocols
• Before testing black listed method, normalize it (trim and lowercase)

// line 113 and 125
_, ok := a.blackList[object.Method]

normalize method

method := strings.ToLower(strings.TrimSpace(object.Method))

• Display method name in the error only if it's a batch request

// single call (because it's known from context)
fmt.Sprintf("method is not allowed", method)
// batch
fmt.Sprintf("method %s is not allowed", method)

• minor: BlackList is one word Blacklist

API key is visible in the history

Unknown if the key is valid or not. Comment for #ebbf511 is "feat:remove apiKey" The key is still visible if you look at the file history.

Feel free to drop this issue if it is not a concern. I don't see a security.md or way to mark this issue as private.