koviubi56 / p2sn

Peer to peer socket network

👋 Hi, I’m @koviubi56

📫 Contact me using Keybase or with email

p2sn's Issues

Improve code quality

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.19%.

Quality metrics	Before	After	Change
Complexity	4.76 ⭐	5.77 ⭐	1.01 👎
Method Length	63.96 🙂	63.31 🙂	-0.65 👍
Working memory	7.73 🙂	8.02 🙂	0.29 👎
Quality	67.69% 🙂	65.50% 🙂	-2.19% 👎

Other metrics	Before	After	Change
Lines	594	692	98

Changed files	Quality Before	Quality After	Quality Change
src/p2sn/init.py	65.59% 🙂	63.52% 🙂	-2.07% 👎
tests/test_p2sn.py	94.41% ⭐	93.68% ⭐	-0.73% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
src/p2sn/init.py	Server._handle	18 🙂	191 😞	13 😞	37.48% 😞	Try splitting into smaller methods. Extract out complex expressions
src/p2sn/init.py	Server._handle_pubkey	5 ⭐	227 ⛔	12 😞	47.97% 😞	Try splitting into smaller methods. Extract out complex expressions
src/p2sn/init.py	Client.init	5 ⭐	291 ⛔	7 🙂	55.17% 🙂	Try splitting into smaller methods
src/p2sn/init.py	Request.__init__	10 🙂	134 😞	9 🙂	57.04% 🙂	Try splitting into smaller methods
src/p2sn/init.py	Server._recv_msg	7 ⭐	137 😞	9 🙂	59.51% 🙂	Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Originally posted by @sourcery-ai[bot] in #5 (comment)

Specify "+" and "/" in base64 encode/decode, don't rely on defaults