getMaxChars cant be more then 1000 about esmska

[peci1]

Can't it be related to #470 ?

[tomaskovacik]

what ever 💃
having some hard limit somewhere in code and then read other number from config file and do not check whatever is that number usable in next calculation (1000/1404 must be at least 1) and then don't allow user to send sms is bug

in my opinion: value from *.gateway should be tested and if its greater then 1000 we should change maxMessageLength.

i do not go to debate whatever is hard limit maxMessageLength good/bad I understand why it is there, and also disagree that is somehow useful ..... this is about not functional gateway, so I just want to know how author of esmska want to have fixed this.

Me as author of gateway want to have it fully functional so 1404 chars per one request

t.

[peci1]

Then let's try to fix it in a Pull Request. @kparal no longer has time for bugfixes.

[kparal]

3325731 should fix it. I could publish a new esmska release, even though something tells me not that many people use this gateway... the problem has probably existed for years. Is it important for you?
The message length is now hard capped at 1000 chars (even if the gateway defines a higher value).

[tomaskovacik]

isn't update of gateway automaticly downloaded by clients? if so, fix of gateway is ok. I do not use it, so it's just to have it fixed.

[kparal]

I fixed it in program itself, not gateway. But it's true that we can simply change the max limit from 1404 to 1000 and the problem is fixed even with a gateway update. Will do that.