kpeng / node-ringbuffer Goto Github PK

It would be great if support for an operation that empties the buffer was supported.

It is currently possible to do this with buffer.get() or by creating a new object but it should be trivial to implement a flush method that just resets all the offsets.

I'm happy to implement and put this into a pull request.

One small suggestion: would it be a good idea to add support for a peek method that does not copy the data? This should be possible using Buffer.slice:

[http://nodejs.org/api/buffer.html#buffer_buf_slice_start_end]

I suppose that would allow the caller to modify the contents of the buffer and break encapsulation but it would improved performance.

I'm happy to submit a pull request with this or fork.

Otherwise loved the code and will start using it soon!

Thomas