krakenfx / wallet Goto Github PK

Support for LN deposits using unified QR codes should be great IMHO:

https://bitcoinqr.dev/

I hope the wallet can have a built-in dapp browser

It should be great to have direct Kraken wallet releases from GitHub APK & F-Droid IMHO.

As titled, when you send funds and they're pending confirmation, the amount spent on fees for some reason still counts towards your available balance, even though there are no UTXOs owned by the wallet at all. In the image the fee paid was ~$2.05 as shown in the available balance:

Hello Krakenites,

I was interested in contributing to your open-source project and decided to try to deploy it locally.
Unhappily there seems to be some missing files. Some that I already found:

• on /src/App.tsx I can't import this line import { runMigrations } from './utils/migrations';
• on /src/hooks/useDebugInfo.ts this statement this require won't work: const gitInfo = require('/git-info.json');

After commenting those lines I still struggle with the following error:

error: node_modules/react-native-reanimated/src/reanimated2/core.ts: .../kraken-wallet/node_modules/react-native-reanimated/src/reanimated2/core.ts: Cannot find module '@babel/plugin-proposal-optional-chaining'

I have tried with and without Expo Go, just to get the same result. So, I guess I am out of luck.
I would be happy to assist you in making it easy for contributors to get onboarded on this project.

Cheers,
Pedro

When testing out the Bitcoin portion of the wallet, I noticed that received funds are incorrectly marked as sends, and show the recipients address as the sending address. That also means that the amount of the transaction is displayed incorrectly. The pictured received transaction was from an external wallet to Kraken Wallet.

Android/Iphone is not enough, break us free from coinbase! Make a chrome and firefox extension as well!

I maintain ethereum-cryptography, which was created to combine all ethereum deps in one package. The work was funded by EF in 2021. You are already using it through some of your deps.

Kraken depends on a bunch of unnecessary cryptographic libraries. For example, for secp256k1, you use at least 4 libraries: secp256k1, tiny-secp256k1, elliptic and @noble/curves. Instead of it, one library can be used. Sometimes you are using outdated dependencies, that have not been maintained for years.

A dependency can get an update and add malware to your bundle. This can be combatted:

• by manually checking every dependency upgrade diff
• by utilizing lavamoat sandbox (like metamask does)

It can be assumed that you did not personally audit every line of dependency. Neither did your auditor, because that would be too long and expensive.

You are already using audited noble-hashes and noble-curves through @solana/web3.js, bip32, bip39, ethers and others. I suggest to do following steps:

1. ripemd160 can be replaced by noble-hashes
2. secp256k1 can be replaced by noble-curves
3. slip39 can be replaced by ed25519-keygen, which depends on noble-curves
4. tiny-secp256k1 can be replaced by noble-curves
5. web3 v1.10 can be upgraded to v4 which depends on noble-curves
6. ethereumjs-wallet v1 can be upgraded to v2, which depends on noble-curves and noble-hashes
7. ed25519-hd-key: see 3, is unnecessary
8. crypto-browserify should be removed (last update 6 years ago, unmaintained, lots of deps) and replaced by noble-hashes
9. ecpair can be replaced by noble-curves or scure-btc-signer
10. electrum-mnemonic can be replaced by scure-bip39 (todo: research if feature-parity is achieved)
11. bignumber.js is not needed, can be replaced by native BigInt
12. @metamask/eth-sig-util can be upgraded from v4 to v7, which depends on noble-curves

Hello, will you add support for Ethereum Classic (Chain 61) and its testnet Mordor (chain 63)? We would like to feature the Kraken wallet in the DeFi applications we are building at EthereumClassic.com Thanks in advance!

Firstly, I'd like to commend you on the recent release of your open-source wallet. This initiative is a significant step towards transparency and fosters community involvement, which is commendable.

As a developer interested in contributing to the project, I encountered challenges setting up and running the wallet locally due to the absence of developer documentation. Would it be possible for the team to provide some insights or guidelines on how to develop locally, properly?

Furthermore, implementing GitHub Actions with basic CI tooling would be beneficial. Automating the testing process can enhance code quality and streamline contributions for the community. While I understand GitHub might not be your primary platform, given the security audit I've read, integrating some tooling here could still be advantageous.