Unable to use latest dustjs version due to package.json conflict adaro about adaro

[lmarkus]

I've been experimenting with 2.2.x and that works ok (You don't miss out on any useful stuff with 2.3). I'll leave the issue open, because we should either address it, or make a recommendation.

[mindpivot]

Oh they work with even the latest. When I run locally it works just fine if I'm using the latest version of dustjs-linkedin. The problem comes when I run a

git push heroku master

The resulting building of the dependencies and the compiled "slug" they create fails due to a version mismatch in my package.json dependency and the package.json in Adaro/Makara.

I'd recommend changing the package.json dependency of both to 2.3.2 at the least, or 2.x.x and lock it in tighter if a version ends up breaking the API/signature that is expected.

[totherik]

Hey @mindpivot , dustjs-linkedin is a dev dependency in this module, so it shouldn't be installed when this module is consumed via npm install. (In fact, since dustjs expects to be global, having multiple modules would definitely create unexpected behavior, which is why it's not a direct dependency.) Are you seeing something different or is something being validated incorrectly?

[mindpivot]

This problem actually seems to be makara related as opposed to adaro related, so before I continue let me apologize for posting in the incorrect repo. I should be posting in the makara issues list. But I'll finish out here for sake of completeness.

Ok so here's what's going on. In my package.json I have the following:

{
  "name": "...",
  "description": "...",
  "author": "mindpivot",
  "version": "0.0.4",
  "private": true,
  "scripts": {
    "test": "grunt test",
    "start": "bin/web",
    "postinstall": "grunt build"
  },
  "dependencies": {
    "kraken-js": "~0.7.0",
    "express": "~3.4.8",
    "adaro": "~0.1.x",
    "nconf": "~0.6.9",
    "less": "~1.6.1",
    "makara": "~0.3.3",
    "mongoose": "~3.8.5",
    "newrelic": "~1.3.0",
    "connect-mongo": "~0.4.0",
    "connect-flash": "~0.1.1",
    "view-helpers": "~0.1.4",
    "async": "~0.2.10",
    "dustjs-helpers": "~1.1.2",
    "bcrypt": "~0.7.7",
    "passport": "~0.2.0",
    "passport-local": "~0.1.6",
    "dustjs-linkedin": "~2.3.2", // Note version here
   ...
}

When I build and run locally using foreman, no issues. However, when I then commit everything in git then push using the heroku command:

$ git push heroku master

This is the first error in the console output (see attached text for entire log):

       npm ERR! peerinvalid The package dustjs-linkedin does not satisfy its siblings' peerDependencies requirements!
       npm ERR! peerinvalid Peer [email protected] wants dustjs-linkedin@~2.0.0

       npm ERR! System Linux 3.8.11-ec2
       npm ERR! command "/tmp/build_4a748da6-10f7-4221-9c2c-429a7eaf77ac/vendor/node/bin/node" "/tmp/build_4a748da6-10f7-4221-9c2c-429a7eaf77ac/vendor/node/bin/npm" "install" "--userconfig" "/tmp/build_4a748da6-10f7-4221-9c2c-429a7eaf77ac/.npmrc" "--production"
       npm ERR! cwd /tmp/build_4a748da6-10f7-4221-9c2c-429a7eaf77ac
       npm ERR! node -v v0.10.25
       npm ERR! npm -v 1.3.24
       npm ERR! code EPEERINVALID
       npm ERR! 
       npm ERR! Additional logging details can be found in:
       npm ERR!     /tmp/build_4a748da6-10f7-4221-9c2c-429a7eaf77ac/npm-debug.log
       npm ERR! not ok code 0
0 info it worked if it ends with ok

The error seems to be due to the "peerDependencies" configuration in Makara's package.json. It explicitly declares the 2.0.0 release of dustjs-linkedin without any room for wiggle. Heroku's build process is seeing that and failing. When I remove Makara (which I may still do, I've been on the fence about doing Internationalization for this) the Heroku build works fine..

Again, apologies for cross-posting to the wrong repo.

heroku-error.txt | uploaded via ZenHub

[jeffharrell]

This should be fixed as of krakenjs/makara#34