GithubHelp home page GithubHelp logo

Comments (12)

sethkinast avatar sethkinast commented on July 18, 2024

dust.load isn't part of the exposed API anymore. I'ma take a look at how we can refactor the code that needs to patch it (dustjacket).

from adaro.

aredridel avatar aredridel commented on July 18, 2024

Oh dear. Alright! I really wish dust would adopt semver.

from adaro.

pvenkatakrishnan avatar pvenkatakrishnan commented on July 18, 2024

+1 to semver.

from adaro.

sethkinast avatar sethkinast commented on July 18, 2024

For better or for worse, Dust versioning policy is such that you should lock to a minor version (not a major) to avoid breakages.

e.g. "dustjs-linkedin": "~2.6"

Maybe it can change in Dust 3...

from adaro.

sethkinast avatar sethkinast commented on July 18, 2024

Although dustjacket (and adaro) don't explicitly lock Dust versions anywhere so I am not sure you would be saved anyways :P

from adaro.

aredridel avatar aredridel commented on July 18, 2024

Indeed. We demand apps do that (and that's what npm3 will pay attention to) -- peer dependencies are becoming advisory.

from adaro.

ricardohbin avatar ricardohbin commented on July 18, 2024

The peerDependencies of dustjs-helpers can cause troubles too. Make sure to downgrade it too ->

    "dustjs-helpers": "~1.6"
    "dustjs-linkedin": "~2.6.0"

from adaro.

aredridel avatar aredridel commented on July 18, 2024

Yep! Well aware of that one. Dust versioning is a mess.

from adaro.

ricardohbin avatar ricardohbin commented on July 18, 2024

This commit linkedin/dustjs@885d7e2#diff-6837aa089aead29d68bfb62936171c2bL93 :P

from adaro.

aredridel avatar aredridel commented on July 18, 2024

Yup! linkedin/dustjs#641 is a good attempt at adding the infrastructure to do an equivalent to what we need.

from adaro.

aredridel avatar aredridel commented on July 18, 2024

Fixing this will be a breaking change, so I'm preparing an adaro 1.0 release.

from adaro.

aredridel avatar aredridel commented on July 18, 2024

Fixed in #69

from adaro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.