krasun / lsmtree Goto Github PK

Check data files on open by the checksum.

Hi @krasun

I think the memtable bytes are calculated in wrong way on delete. It only subtracts the size of deleted value if the key doesn't exist in the underlying tree.

func (mt *memTable) delete(key []byte) error {
	value, exists := mt.data.Put(key, nil)
	if !exists {
		mt.b -= len(value)
	}
	return nil
}

to calculating the bytes more precisely:

• subtracting the size of deleted value if the key exists.
• adding the size of the key if the key doesn't exist.

Option to write to file without sync and additional function to sync the changes when requested.

Just wondering how proper merge and compaction can take place without time stamp data being encoded to the disc table?

I would be more than happy too help out with this project if you are looking for participants.

Use specific types like uint32 instead of int for encoding and ensure that there are no overflows.

Merge and flush MemTable on foreground/background/manually with the callback on the error.

Use global mutex for synchronization.

Use ReadWriteCloser for WAL or implement separate abstraction.