krizzu / eslint-check-action

GitHub action running eslint check in your project, annotating errors/warnings in PR.

Hello 👋

I'm a software developer, located in Wrocław, Poland 🇵🇱

I specialize in mobile apps development, leveraging frameworks such as React Native, Jetpack Compose and sometimes SwiftUI. Also exploring cross-platform solutions, such as Kotlin Multiplatform.

eslint-check-action's Issues

How to cache docker image

Hi! I find your action really useful, but the build time lasts quite long since it downloads the image on each build. Is there a way to cache the image between builds?

Thanks!

Keep getting ##[error]You must authenticate via a GitHub App.

Have the default template you have on the README in my CI Github Action and seeing this error.

Failure and Error thrown when > 50 issues found

Trying this action out on an existing codebase and encountering an Error with a failure of:

No more than 50 items are allowed; 169 were supplied.

It would seem that this is a result of the limit on Annotations to be added in a single API request, as per https://developer.github.com/v3/checks/runs/

The Checks API limits the number of annotations to a maximum of 50 per API request. To create more than 50 annotations, you have to make multiple requests to the Update a check run endpoint. Each time you update the check run, annotations are appended to the list of annotations that already exist for the check run. For details about how you can view annotations on GitHub, see "About status checks".

Invalid request

with

jobs:
  eslint_check:
    name: prepare
    runs-on: ubuntu-latest
    steps:
    - name: Checkout 
      uses: actions/checkout@v1
    - name: Install dependencies
      run: yarn install
    - name: Lint
      uses: Krizzu/[email protected]
      with:
        ghToken: ${{ secrets.GITHUB_TOKEN }}
        eslintExt: "vue"
        eslintConfig: ".eslintrc.js"

file .eslintrc.js in root of repository

Where to put config file?

Okay, I tried it with a .eslintrc in my project root directory and it worked.

I tried it with a .eslintrc.json specifying it like this:

name: Lint
on: [push]
jobs:
  eslint_check:
    name: Prepare action
    runs-on: ubuntu-latest
    steps:
      # Checkout action must run prior to eslint check
    - name: Checkout 
      uses: actions/checkout@v1
    - name: Lint
      uses: Krizzu/[email protected]
      with:
        ghToken: ${{ secrets.GITHUB_TOKEN }}
        eslintConfig: "eslintrc.json"

and it fails with:
##[error]Cannot read config file: /github/workspace/eslintrc.json

the .eslintrc.json is in the exact same directory (root).

I also tried "./eslintrc.json"

Use Existing Github Check

Is it possible to run this action without creating a new Check? My goal would be to utilize the existing "test" check instead of creating a new "Eslint Run" check, which clutters up the check list view.

Update eslint to latest version

Is there a reason this action still uses eslint 6.6.0?

How do we setup eslint.config.js? Is it required or can we remove that from the workflow file?