ksenzee / views3ui Goto Github PK

Move the "remove" links/checkboxes from the rearrange forms to the bulk delete form.

If you look carefully at the designs, there aren't supposed to be any spaces between buckets. I missed that when I wrote the original CSS.

This description is no longer relevant to what's left to be done, but leaving it for history. See comments.

i.e. finish the menu structure rearrangement

• create some kind of placeholder at admin/structure/views/view so the breadcrumbs work
• set a page title on the edit view screen
• resolve conflict in hook_menu that resulted in a bunch of commented-out code

Currently seems to be striping per group instead of overall. Quick fix would be to run the JS restriping method after the page loads.

remove items via the edit form instead of the rearrange form; get rid of the "remove" checkboxes and links from the rearrange form, and add remove buttons to the configuration forms

Discuss: Are we getting rid of the remove checkboxes everywhere, or only on some screens?

Views fields designs: http://viewsdesigns.drupalgardens.com/content/views-fields

1. The "multiple field settings" is a new fieldset (as of a recent Views update).
2. There are several other field-related settings ("click sort column", "formatter", "use field template") that views itself just tends to dump at the bottom of the form. For us they wind up at the top.

These extra field-related settings referenced in (2.) above should be dumped in the More fieldset.

When a display is deleted, it should be marked as deleted and recoverable via an "Undo delete" button. See designs.

Compare https://skitch.com/effulgentsia/rxywy/add-new-view-localhost and http://viewsdesigns.drupalgardens.com/media-gallery/detail/26/191. Or, is the design outdated?

As on http://viewsdesigns.drupalgardens.com/sites/viewsdesigns.drupalgardens.com/files/styles/media_gallery_large/public/15_Add_filters.png

i.e. sometimes "edit", "duplicate" and "delete" spill over to a second line - they shouldn't ever do that. Maybe separate operations with a non-breaking space.

http://img534.imageshack.us/i/screenshot2ww.png/

The Views UI tests are located at tests/views_ui.test. They passed at the beginning of the code sprint. It would be good if they pass at the end too :)

Apart from Apply and Cancel, there should be a Remove button in every edit dialog (fields, filters, arguments)

According to http://viewsdesigns.drupalgardens.com/media-gallery/detail/6/66 the contextual links/title needs some styleing.

• The section-titles have to be smaller
• The contextual settings button should be on the left on appear everytime (this might require some js work, too)
• Perhaps some more stuff

Jeff will deliver the mockup for the preview form tomorrow (15th).
After that, the preview form can get styled.

Notes:

1. Should the "Auto preview" checkbox be on the left, like on the mockups, instead of on the right, like now?
2. There's an Arguments textbox shown if there are arguments added. So we need to make sure the form looks good in both cases (arguments textbox present, or just the preview button present)

Request from Jeff. Easy to do. Just need consensus: https://skitch.com/jeff.noyes/rxfir/add-new-view-jeffer

go through all the sort criteria edit forms and make sure they conform to the new design

This happens for example when adding a filter.

make tablesort work; add and/or operators to the left of each filter group

Note: This is mostly done, and may even be fully done by now.

Also, try to make it easy to alter that wording back to "template" in Gardens.

• make the machine name a tooltip on the listing page
• add the display name at the top of the edit form, where "View name" is currently
• add a machine name option over in "Other" so it can be edited

Have fun Earl.

maybe check with Jeff about how he thinks they should look

If there's a PDO (or other) exception in a view, you get the dreaded "unexpected error" page when you try to edit the view. BTW, another way to fix this would be moving the preview into its own page callback and only invoking it via ajax (this is how views currently does it). But the disadvantage of that is that non-JS users don't get to see the preview on the same page as the edit screen.

get rid of the associated variables too if any.

• rearrange links should show up only when there are < 2 things in a bucket
• on filter criteria, it should be the existing gear icon
• on everything else, it should show as an up/down arrow icon

The settings links got added to the views edit page.

The style: http://viewsdesigns.drupalgardens.com/media-gallery/lightbox/6/76

Currently it looks like
"Content settings |" even the output looks okay.
The problem seems to be the left floated links

Maybe make it float on top of the page instead.

In Views 2 and Views 3 (6.x branch) an icon indicates that an option has more options inside.

Here is the original issue: http://drupal.org/node/534680

And this is how is at this moment in:
Views 6.x-3.x http://img62.imageshack.us/i/drupal63.png/ (with padding and icon)
Views 7.x-3.x http://img813.imageshack.us/i/drupal73.png/ (doesn't have padding)
Views on Github: http://img337.imageshack.us/i/drupall7ux.png/ (without icon and padding)

some we know don't work include "click sort column", "formatter", "use field template" (when configuring fields) - Jeff suggested throwing them in the "More" fieldset

As you see on http://viewsdesigns.drupalgardens.com/media-gallery/detail/6/66 it should be possible to edit the title of a view.

Therefore the title itself has to be displayed

Example of the issue:
https://skitch.com/jesse.beach/rq2cq/home-site-install

1. Scroll to the bottom of the preview area when editing a view.
2. Note the "Pager" header above the paging numbers.

Also make all the settings have their intended effect, except "show filters on the list of views" which is a separate issue

we're doing this so that there are at least two options - otherwise the form where you choose something to add only has one option.

see designs

When you create a new view a click to the enter key should automatically move the user to the views edit screen

"Module/Theme/Theme engine", for example. Figure out what to do about them.

The whole filter criterion edit form needs to be rearranged per the designs

• move "Administrative title" to a "more options" fieldset
• move checkboxes to the right and put them in a scrolling div
• add an "All" checkbox at the top that does multi-select
• put other stuff into "more options"

Basically when you click "Apply" on the second to last one, it acts like you clicked "Expose" instead, and then never lets you configure the last filter.

• On the Settings tab, add a checkbox for whether to enable filtering on the List page.
• If the setting is enabled, then on List page, display the filtering controls
• Make the 'type' and 'display' filters work
• Make sortable by view name and path. If a view has multiple paths, this applies to the first one.
• Don't use tablesort - it won't work, per Earl.

fix.

Since 74f523a
and e2c79bf

It's possible to delete a display, but the display remains.

Once a display is removed the edit region itself get's views-display-deleted and the link views-display-deleted-link

This needs styling based on http://viewsdesigns.drupalgardens.com/media-gallery/lightbox/6/121