kubernetes-csi / csi-driver-iscsi Goto Github PK

run golangci-lint
  Running [/home/runner/golangci-lint-1.29.0-linux-amd64/golangci-lint run --out-format=github-actions -E=gofmt,golint,misspell --timeout=30m0s] in [] ...
  Error: Error return value of `iscsiLib.Disconnect` is not checked (errcheck)
  Error: Error return value of `server.Serve` is not checked (errcheck)
  Error: Error return value of `flag.Set` is not checked (errcheck)
  Error: Error return value of `flag.CommandLine.Parse` is not checked (errcheck)
  Error: Error return value of `cmd.MarkPersistentFlagRequired` is not checked (errcheck)
  Error: Error return value of `cmd.MarkPersistentFlagRequired` is not checked (errcheck)
  Error: exported func NewDriver returns unexported type *github.com/kubernetes-csi/csi-driver-iscsi/pkg/iscsi.driver, which can be annoying to use (golint)
  Error: exported func NewNodeServer returns unexported type *github.com/kubernetes-csi/csi-driver-iscsi/pkg/iscsi.nodeServer, which can be annoying to use (golint)
  Error: type name will be used as iscsi.ISCSIUtil by other packages, and that stutters; consider calling this Util (golint)
  Error: `ns` is unused (structcheck)
  Error: S1023: redundant `return` statement (gosimple)
  Error: S1023: redundant `return` statement (gosimple)
  
  Error: issues found
  Ran golangci-lint in 109779ms

[root@cp-dev-2 ~]# kubectl -n kube-system logs -f csi-iscsi-node-6pgt9 iscsi
I0330 17:56:50.193869       1 driver.go:43] driver: iscsi.csi.k8s.io version: 0.2.0 nodeID: 192.168.39.211 endpoint: unix:///csi/csi.sock
I0330 17:56:50.193962       1 driver.go:84] enabling volume access mode: SINGLE_NODE_WRITER
I0330 17:56:50.193987       1 driver.go:95] enabling controller service capability: UNKNOWN
I0330 17:56:50.234056       1 server.go:103] listening for connections on address: &net.UnixAddr{Name:"//csi/csi.sock", Net:"unix"}
I0330 17:56:50.511513       1 utils.go:63] GRPC call: /csi.v1.Identity/GetPluginInfo
I0330 17:56:50.511542       1 utils.go:64] GRPC request: {}
I0330 17:56:50.516116       1 identityserver.go:32] using default GetPluginInfo
I0330 17:56:50.516133       1 utils.go:69] GRPC response: {"name":"iscsi.csi.k8s.io","vendor_version":"0.2.0"}
I0330 17:56:50.746464       1 utils.go:63] GRPC call: /csi.v1.Identity/GetPluginInfo
I0330 17:56:50.746487       1 utils.go:64] GRPC request: {}
I0330 17:56:50.746541       1 identityserver.go:32] using default GetPluginInfo
I0330 17:56:50.746547       1 utils.go:69] GRPC response: {"name":"iscsi.csi.k8s.io","vendor_version":"0.2.0"}
I0330 17:56:51.205393       1 utils.go:63] GRPC call: /csi.v1.Node/NodeGetInfo
I0330 17:56:51.205425       1 utils.go:64] GRPC request: {}
I0330 17:56:51.205509       1 utils.go:69] GRPC response: {"node_id":"192.168.39.211"}
I0330 17:56:57.451445       1 utils.go:63] GRPC call: /csi.v1.Node/NodeGetCapabilities
I0330 17:56:57.451466       1 utils.go:64] GRPC request: {}
I0330 17:56:57.451513       1 utils.go:69] GRPC response: {"capabilities":[{"Type":{"Rpc":{}}}]}
I0330 17:56:57.452618       1 utils.go:63] GRPC call: /csi.v1.Node/NodePublishVolume
I0330 17:56:57.452630       1 utils.go:64] GRPC request: {"target_path":"/var/lib/kubelet/pods/c51982c1-03af-4362-ab59-bf7c943c1594/volumes/kubernetes.io~csi/iscsiplugin-pv/mount","volume_capability":{"AccessType":{"Mount":{}},"access_mode":{"mode":1}},"volume_context":{"discoveryCHAPAuth":"false","iqn":"iqn.2022-03.local.alauda.server:disk1","iscsiInterface":"default","lun":"0","portals":"[]","sessionCHAPAuth":"false","targetPortal":"192.168.39.212:3260"},"volume_id":"iscsi-data-id"}
I0330 17:56:57.453002       1 mount_linux.go:163] Detected OS without systemd
E0330 17:56:57.454656       1 utils.go:67] GRPC error: rpc error: code = Internal desc = chroot: failed to run command 'iscsiadm': No such file or directory

+ go build -a -ldflags ' -X main.version=991e8fb04982913f68afdaaf5af265fefc715e1b  -extldflags "-static"' -o ./bin/iscsiplugin ./cmd/iscsiplugin
# github.com/kubernetes-csi/csi-driver-iscsi/pkg/iscsi
pkg/iscsi/driver.go:76:22: cannot use NewControllerServer(d) (type *ControllerServer) as type csi.ControllerServer in argument to s.Start:
	*ControllerServer does not implement csi.ControllerServer (missing ControllerGetVolume method)
note: module requires Go 1.16
Building iscsiplugin for GOOS= GOARCH= failed, see error(s) above.
make: *** [release-tools/build.make:81: build-iscsiplugin] Error 1

[root@hchiramm csi-driver-iscsi]# kubectl logs csi-iscsi-node-drtws -c iscsi 
Error: invalid argument "5 --nodeid=127.0.0.1 --endpoint=unix:///csi/csi.sock" for "-v, --v" flag: strconv.ParseInt: parsing "5 --nodeid=127.0.0.1 --endpoint=unix:///csi/csi.sock": invalid syntax
Usage:
  iscsi.csi.k8s.io [flags]

Flags:
      --add_dir_header                   If true, adds the file directory to the header of the log messages
      --alsologtostderr                  log to standard error as well as files
      --endpoint string                  CSI endpoint
  -h, --help                             help for iscsi.csi.k8s.io
      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
      --log_dir string                   If non-empty, write log files in this directory
      --log_file string                  If non-empty, use this log file
      --log_file_max_size uint           Defines the maximum size a log file can grow to. Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
      --logtostderr                      log to standard error instead of files (default true)
      --nodeid string                    node id
      --one_output                       If true, only write logs to their native severity level (vs also writing to each lower severity level)
      --skip_headers                     If true, avoid header prefixes in the log messages
      --skip_log_headers                 If true, avoid headers when opening log files
      --stderrthreshold severity         logs at or above this threshold go to stderr (default 2)
  -v, --v Level                          number for the log level verbosity
      --vmodule moduleSpec               comma-separated list of pattern=N settings for file-filtered logging

invalid argument "5 --nodeid=127.0.0.1 --endpoint=unix:///csi/csi.sock" for "-v, --v" flag: strconv.ParseInt: parsing "5 --nodeid=127.0.0.1 --endpoint=unix:///csi/csi.sock": invalid syntax[root@hchiramm csi-driver-iscsi]# 

[root@hchiramm csi-driver-iscsi]# kubectl describe pod csi-iscsi-node-drtws |grep -i image
    Image:         k8s.gcr.io/sig-storage/livenessprobe:v2.1.0
    Image ID:      docker-pullable://k8s.gcr.io/sig-storage/livenessprobe@sha256:b0a9eb3e489150d79bff1c97681f34c579e6fcb1a4ed0289c19180eb83ebc83d
    Image:         k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.1.0
    Image ID:      docker-pullable://k8s.gcr.io/sig-storage/csi-node-driver-registrar@sha256:a61d309da54641db41fb8f35718f744e9f730d4d0384f8c4b186ddc9f06cbd5f
    Image:         gcr.io/k8s-staging-sig-storage/iscsiplugin:canary
    Image ID:      docker-pullable://gcr.io/k8s-staging-sig-storage/iscsiplugin@sha256:127d8f5422b291d54eb9119eb9c1350e288325b942fb52c3b80e1750f4b2de9d
  Normal   Pulled     3m15s                  kubelet            Container image "k8s.gcr.io/sig-storage/livenessprobe:v2.1.0" already present on machine
  Normal   Pulled     3m15s                  kubelet            Container image "k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.1.0" already present on machine
  Normal   Pulled     2m33s (x4 over 3m14s)  kubelet            Container image "gcr.io/k8s-staging-sig-storage/iscsiplugin:canary" already present on machine
[root@hchiramm csi-driver-iscsi]# 

   - name: csi-proxy-iscsi-pipe
          hostPath:
            path: \\.\pipe\csi-proxy-iscsi-v1beta1
            type: ""

  rpc AddTargetPortal(AddTargetPortalRequest)
      returns (AddTargetPortalResponse) {}

  // DiscoverTargetPortal initiates discovery on an iSCSI target network address
  // and returns discovered IQNs.
  rpc DiscoverTargetPortal(DiscoverTargetPortalRequest)
      returns (DiscoverTargetPortalResponse) {}
...
  // ConnectTarget connects to an iSCSI Target
  rpc ConnectTarget(ConnectTargetRequest) returns (ConnectTargetResponse) {}

  // DisconnectTarget disconnects from an iSCSI Target
  rpc DisconnectTarget(DisconnectTargetRequest)
      returns (DisconnectTargetResponse) {}

$ csc node publish --endpoint tcp://127.0.0.1:10000 --target-path /mnt/iscsi --attrib targetPortal=$ISCSI_TARGET --attrib iqn=$IQN --attrib lun=<lun-id> iscsitestvol

[hchiramm@localhost csi-driver-iscsi]$ grep -iR "github.com/kubernetes-csi/csi-lib-iscsi" * --color
go.mod:	github.com/kubernetes-csi/csi-lib-iscsi v0.0.0-20200629134124-4eea777a2dc3
go.sum:github.com/kubernetes-csi/csi-lib-iscsi v0.0.0-20200629134124-4eea777a2dc3 h1:wXFH8cdGsfC7gibAZfolMASqCLsuqt3cbiy44hWkcLU=
go.sum:github.com/kubernetes-csi/csi-lib-iscsi v0.0.0-20200629134124-4eea777a2dc3/go.mod h1:4lv40oTBE8S2UI8H/w0/9GYPPv96vXIwVd/AhU0+ta0=

+ go build -a -ldflags ' -X main.version=991e8fb04982913f68afdaaf5af265fefc715e1b  -extldflags "-static"' -o ./bin/iscsiplugin ./cmd/iscsiplugin
# github.com/kubernetes-csi/csi-lib-iscsi/iscsi
vendor/github.com/kubernetes-csi/csi-lib-iscsi/iscsi/iscsi.go:379:7: no new variables on left side of :=
Building iscsiplugin for GOOS= GOARCH= failed, see error(s) above.
make: *** [release-tools/build.make:81: build-iscsiplugin] Error 1