kumpelblase2 / nmsmapper Goto Github PK

@NMSMethod("a")
public void test(@NMSWrap MyInterface val) {
    this._test(val); // this does not work
}

There should be a way to make this work again without having to cast to that parameter.

Right now you can override methods like this:

class B {
   public void b() {
      // Do something
   }
}

@NMS
class A extends B {
   @NMSMethod("b")
   public void myB() {
      //do something else
   }
}

Which is cool but most of the times I don't want to completely override the method, just extend it or alter the parameters before or after the execution. Normally you'd just call super.myB() (in this case) and that would be fine. But here, since myB only got introduced in the class you're using, there's no super to call. Having to call super.b() is destroying the purpose of doing these mappings.

Following scenario:

class A {
  void toOverride() {}
}

class Base extends A {
  @NMSMethod("toOverride")
  void myCustomMethod() {}
}

@NMS("package.A")
class C extends Base {
}

1. Should this work?
2. Should Base also require an annotation?
   a) Should it require some marker to tell it it's a super class, like @MappedSuperclass for JPA