GithubHelp home page GithubHelp logo

3's People

Watchers

 avatar

3's Issues

convertFromHTML anchor tags href conversion issues

Do you want to request a feature or report a bug?
bug

What is the current behavior?
When using convertFromHTML with anchor tags with href's such as:
<a href="let_me_feel_my_feelings_please" > thanks </a>,
The content state will have the link with the url as: "http://localhost:8080/let_me_feel_my_feelings_please"
or whatever the current domain is added in front.

This happens bc in the code, convertFromHTMLToContentBlocks.js around line 640 (0.11.4), in method _addAnchorNode, the href is being extracted from the DOM node like this entityConfig.url = new URI(anchor.href).toString();

Can we please just grab the attribute so that we can allow for other uri schemes? Like so:
entityConfig.url = new URI(anchor.getAttribute('href')).toString();

This would be awesome

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?
I am using 0.11.4

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.