kury25 / moodle-assignfeedback_editpdfplus Goto Github PK

Hi,

Nowadays there is no need to include language files for languages other than English inside the plugin downloadable ZIP file. Please read https://lang.moodle.org/mod/forum/discuss.php?d=2485 .

I have already sent them to the AMOS french language maintainers and, if accepted, should soon be incorporated into the franch language pack. I will write you when they do, so that you can then remove them from here.

Thanks in advance

Inline comments currently appear with a transparent background when downloaded in PDF. Could we have the option of a background fill please?

In DB, axishas contextid. Is it really necessary that tool and typet also have the same info?

https://github.com/Kury25/moodle-assignfeedback_editpdfplus/blob/master/db/install.xml#L100

Restoring a course assignment throws the following, which looks like it's this plugin not having a restore method defined?

Restore method process_assignfeedback_editpdfplus_feedback_editpdfplus_pagerotation is missing. It must be defined by a developer.

Currently comments appear as footnotes at the bottom of the downloadable PDF. Where space is limited that is good, but often it is better to see the comment alongside / near the actual work, like the stamps. Can we please have an option on the tool to view the comment inline?

The second and subsequent lines of a Multiline inline annotation, appear at the left instead of aligned under the first line, when viewed in downloaded feedback PDF.

add admin option to not delete student's comment when teacher publishes a new version of annotations

I'm a PT-PT translator in AMOS.
Some strings in the plugin are hardcoded. Is it possible to translate them?
THXS

when selecting wrench button from grading screen, displays blank page and error in log:
PHP Fatal error: Class 'assign_feedback_plugin' not found in /srv/www/pyspace.org/html/vle/mod/assign/feedback/editpdfplus/locallib.php on line 33
Hacked a fix by adding:

require_once($CFG->dirroot . '/mod/assign/feedbackplugin.php');

to line 29
moodle version is 3.8.4+ (Build: 20200723)

If you use symbols such as ticks and crosses in stamps, they appear as question marks in the final downloadable PDF file. I have attached a simple example.
ThisIsATest.pdf

Hi. I'm getting an error message on assignments when the Annotate PDF Advanced plugin is enabled.
It throws an "exception - argument 1 passed to assign::calculate_properties() must be an instance of stdclass, null given, called in [dirroot]/mod/assign/locallib.php on line 1705" error.
I'm using Moodle 3.10 (Build 20201211).
I need this particular plugin to work, so disabling it doesn't solve my problem.

REPLICATE:

• configure assignment to accept feedback for annotate advanced
• file extension PDF
• Login as student and an upload PDF file that contains vertical A4 page follow by Horizontal page
• Login as a trainer and click on Grade
  You should see the first page correctly where the second page should contain CUT text.

ENVIRONMENT SUMMARY

• Moodle 3.8.6+ (Build: 20201224)
• Annotate PDF advanced 2.3.5 (Build: 2019070102)

Tried on Moodle 3.6 and 3.7 no issue detected, this issue showed after upgrade to Moodle 3.8

The same document is correctly showed if using Annotate PDF

The same document is incorrectly showed if using Annotate PDF Advanced

Some users report the grading interface throws an error when trying to annotate a document, if the pathtogspath is not defined correctly.

Also see https://moodle.org/mod/forum/discuss.php?d=376062 (in German)

Then i check my course size i see that assignfeedback_editpdf size very very big, but no one use it in this course. I loose connection to my moodle site and in hurry try to delete temp/assignfeedback_editpdf folders inside. Then i got back to my site i delete plugin and delete some students answers. And i disable assignfeedback_editpdf cron job. Right now i run cron job to clear some trash can files etc, but it not worked good. I delete manual content from trashdir and it free some space. But in course size it still presents.
UPD. I think it is not plugin problem. I found same problem on https://tracker.moodle.org/browse/MDL-69570
Riht now i have some orphan file and big autobackup(change it to file server)
Sorry!
UPD 2:
I clear all this file by using smoosh command:
moosh file-list -i 'component="assignfeedback_editpdf"' | moosh file-delete -s
moosh file-delete --flush
It delete all this files. You can check this file using smoosh and look on all file in you course.
Similar to this i delete all ghsot autobackup.
So it was me who didnt know about annotation feature. And you plugin very nice!

Would it be possible to create language strings for "Comment Lexique Repetion Ponctuation" ( as shown in the buttons" https://www.screencast.com/t/1nNfU1NrSxQz) so that they can be changed in the Moodle language file (https://www.screencast.com/t/kfrnX85VU). We are looking to translate these buttons into English. Thanks very much.

After installing this plugin, when creating a new assignment in any of my courses, the following error occurred:

Exception - Argument 1 passed to assign::calculate_properties() must be an instance of stdClass, null given, called in [dirroot]/mod/assign/locallib.php on line 1705

Admittedly, I am using the plugin with moodle 3.8, which you have not verified your build for, yet, but most plugins have continued to work and I assume you'll eventually want to get your plugin working on 3.8. I uninstalled this plugin and moodle is working fine again, so it is definitely your plugin's interaction with assignments.

Steps to reproduce:

• Navigate to a class
• Enable editing
• Add an activity or resource
• Select Assignment
• Exception is thrown

String errors reported:

Hello, I installed the plugin in moodle 3.11 and when activating the option of qualification with rubric, the floating window is paralyzed, someone else has the same problem? Will there be a version of the plugin compatible with moodle 3.11?