kutaybuyukkorukcu / devnews-fv

Devnews v0.0.1

devnews-fv's Issues

Usage of design pattern in the future because of the extension of crawler types

Behaivoral design pattern -> prob strategy.

Improvement

counterValue() fonksiyonu url'ler crawl edilirken unique Id atamak icin kullaniliyor.

Her kayit icin Id'yi belirlemek icin counterValue() kullanmaktansa collection'da bulunan bir onceki kayitin id'si alinip ona +1 ekleyip, yeni kayida Id atanabilir.

// Bad wording. But i know i'll get it so nw.

Annoying stuff maybe??? - Open 4 discussion.

request to v1/recommend -> database de kisinin begendigi makalelerin linkleri URL collectioni altinda tutuluyor. v1/recommend calistigi zaman bu article linkler crawllanip Like collectionu icerisine yazilir.

v1/recommend is a one per week request so it might not be a problem to think about.

The kick is we have to update isNew field from true to false every single week in order to avoid conflict.

Unit testing for service layer

3.5 out of 6 services are already done.

Will continue later.

Implementing new crawler endpoint for subreddits

Implementing new crawler endpoint for subreddits

User Operations and JWT implementation

Handling user operations

Login, register, JWT etc.

API response

Making API to return a template class composed of status code, message, data and status (error, success)

When transitioning to Spring Framework i should use Response Entity.

@Transactional alternative

using @transactional on service layer

Need an alternative for @transactional currently not using Spring

embed JWT into authorization header before every api call -- Check for best practice

Check for best practice. (React)

Also don't forget to check Spring Security's solution to resolving JWT on every single request.

Exception Handling

https://stackoverflow.com/questions/54677994/service-and-controller-layer-exception-handling-design-pattern

Catch from service layer and throw into - handle on controller or

Catch from service layer using Optional OrElse and handle on controller

Implementing DI

Still searching for what do use as DI

Guice, Dagger, javax.inject etc.

wrap service layer returns by Optional

Seperating architecture into 3 layers

split App.java and main() into multiple controllers

App.java contains all the controller and the database stuff.

Make database stuff service layer thing and remove them from controller (inject them into service layer)

Completed issue#32 + Almost halfway throught issue#38

Data/Article isimlendirmesi - Refactor

Data ve Article kavramlarinin isimleri birbirinden ayristirilacak.

Biri raw digeri raw data degil. DB'de data adli collection yerine Article adli collection olmasi daha mantikli.

Data -> Article yapip, Article derken de recommendationdan donen makaleler oldugunu yani recommended content oldugunu belirtmemiz gerekir.

Isimlerdirmelerde degisime gidilecek.

Caching with redis - Later July.

Caching most viewed/visited subreddits. Refresh the cached data every single day and automate the process.

try/catch logging

Implementing slf4j and adding logging functions for try / catch blocks

Service layer - Try/catch or any alternative?

Service katmanindan donen response'u duzenlemek lazim.

Service katmaninda insert() oncesi yapilan kontrollerden gecemiyor ise exception mi atmaliyim? Ve bu exceptioni atarak controller tarafinda try/catch ile yakalayip controller da buna gore mi donus yapmaliyim?

Ornegin API'ma request yapilinca kayit islemi yapiyor. Service katmaninda ekleme de hata cikarsa bu exception controller tarafina nasil gonderilmeli? Approach 1 -> Service katmani tarafinda insert() islemi yapmadan once yapilan kontrollerden gecemiyorsa exception yollanmali ve controller tarafinda bu exception try/catch ile catchlenmeli ve ona gore controller da response atilmali ?

About mongodb's reactive (old async) api

Should i take it as a consideration? Is it worth changing mongodb api?

Issue 1 - Refactor MongoDatabase parameters

Create a static getMongoDatabase() function for decreasing the usage of MongoDatabase parameter in db functions.

refactor articleService namings

Removing Counter domain and getNextArticleIdSequence()

getNextArticleIdSequence()'yu ile ayri bir collection yaratip bu collection uzerinden id hesaplamak yerine Data collectionundaki articleID elemani $inc edilerek auto increment ID fonksiyonu elde edilecektir.