GithubHelp home page GithubHelp logo

Comments (4)

RonaldTreur avatar RonaldTreur commented on June 10, 2024 1

@kwhitley Just adding my voice here, as this issue cost me a few hours to debug yesterday 😅
It feels weird to me that you can use the nice and handy Headers class everywhere but not when using these helpers. It does not just break this consistency, but requiring object-notation feels like a step back for me as well.

If you persist, I would, at the very least, detect the headers are in an unsupported format and alert developers to this. Of course, I should have looked at the code right away, but I just could not believe that Headers would work everywhere but here.

edit: my current workaround is to not use these helpers and always create a new Response from scratch.

from itty-router.

kwhitley avatar kwhitley commented on June 10, 2024 1

Folded on this one - #213 was merged and will be released shortly :)

Thanks for your patience!

from itty-router.

kwhitley avatar kwhitley commented on June 10, 2024

It does - just pass in headers in object-syntax!

json({ success: true }, {
  headers: {
    'set-cookie': 'blah=true'
  }
})

Should do the trick :)

from itty-router.

kwhitley avatar kwhitley commented on June 10, 2024

See: #213

Appx 20 bytes adds support for this, but cascades to not only createResponse(), but all the downstream helpers as well (json, text, etc), so my leaning is not worth the addition when the current implementation is simpler and lower-byte.

from itty-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.