Comments (2)
Love the detailed writeup! Super helpful - should be fixed in 5.0.17
:)
from itty-router.
If anyone is still having issues with this in 5.0.17
, I found that I had to bypass corsify
for redirect responses. I'm not quite sure why, but it works now. Here is my code:
const { preflight, corsify } = cors();
type CFArgs = [Env, ExecutionContext];
// Do not corsify for redirections
const wrappedCorsify = (response: Response, request?: Request): Response => {
if (response?.status === 302) {
return response;
}
return corsify(response, request);
};
const router = AutoRouter<IRequest, CFArgs>({
before: [preflight],
finally: [wrappedCorsify]
});
router
.get('/authorize', (request, env) => {
return Response.redirect(
`https://github.com/login/oauth/authorize?client_id=${env.GITHUB_OAUTH_APP_CLIENT_ID}&scope=gist`,
302
);
}
);
from itty-router.
Related Issues (20)
- Setting up cron trigger? HOT 2
- cors functions are stateful HOT 8
- Nested routers ergonomics HOT 8
- createCors().corsify eats additional Set-Cookie headers HOT 3
- Does `json()` support `headers` in options? HOT 4
- `withContent` returns a 500 when no body is sent HOT 1
- CORS issue, no preflight request shown HOT 6
- PROPOSAL: CORS HOT 4
- multiple set-cookie headers are removed by corsify
- Exception thrown by withContent HOT 5
- Corsify override http error code. HOT 3
- typescript compilation error when using itty-router 5.0.5 HOT 3
- Uncaught TypeError: (src_default.middleware ?? []) is not iterable HOT 4
- TS compilation error when using itty-router 5.0.17 HOT 11
- withContent middleware fails on BunJS HOT 1
- Feedbdack on deprecation of router.handle HOT 2
- Requests in v5 are hanging, examples not working HOT 7
- Nesting route cannot handle request for static assets
- Throw unexpected error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from itty-router.