kwurst / grading-scripts Goto Github PK

bash fetchConvertLab1.sh alice-bob tim-fred

Since not all assignments to be converted are labs, labconvert.py is not a good name.

Proposed new names:
assignmentconvert.py
processassignment.py
processdirectory.py - my favorite so far

Other suggestions?

With a2pdf and pdftk, preferably with directions on where and how to install.

The diagram that Stoney made needs to be updated to show how the workflow works. In particular, it needs to have the arcs labeled. Some of them need to be made bidirectional, or a second arc needs to be added.

The current verbose feature outputs very detailed messages. Allow multiple verbosity levels.

• Lowest level of verbosity should be outputting the just the names of the directories being processed.
• Middle level of verbosity should output the files being processed.
• Highest level of verbosity should output the individual commands.

At a minimum, confirm that the right number of parameters has been passed. If not, print a usage message and exit.

The code consists of two parts

1. Do the conversion for every subdirectory
2. Do the conversion itself.

The first part is the same in every script. We should pull it out into its own file, and have it call the second, assignment-specific conversion code.

Need error handling in the fetchConvert*.sh scripts to rollback changes if it fails to create branches, etc.

It would be nice to generalize the fetchConvertLab*.bash so that there is one script.

$ bash fetchConvertLab.sh config/lab1 alice-bob

Where config/lab1 is a directory that contains 2 files: config.sh and files.txt. config.sh defines variables used by fetchConvertLab.sh. files.txt lists the files you want fetched from the students' repos.

The advantage is to have one script fetchConvertLab.sh. For each new assignment, you would create a folder with config.sh and files.txt. Update those files. Run script.

When you run libconvert.py, and try to stop it using ^C, it keeps running. It should stop. This is really bad when processing many submissions.

I think the problem is that each time you press ^C you are killing the current shell process, which returns control to python, and then python goes on to the next command.

Command or Assignment needs to check the exit value of the shell processes to see if an error has occurred. If an error has occurred it should probably raise an exception.

There should be an option to process a single directory, rather than all subdirectories of the main directory.
The most common case will be to process all subdirectories, but sometimes a student's repository will be pulled late or have to be reprocessed after an error, and so will need to be processed individually, without reprocessing all the other directories.

If the conversion fails on a particular directory (due to a missing file, for example) labConvert.py needs to print an error message and continue running on the following directories.

Stoney suggested that the name for the student repository should include the course name/number/etc so that students don't end up with name conflicts between labs/projects in different courses.

For example, students can't create a Lab1 repository for CS 140, and another Lab1 repository for CS 254.

A better solution would be to name the repository CS-140-Lab1.

What if the student took the course multiple times (not unheard of)? CS-140-BL-S1-2013-Lab1? That's what I've been doing!

Change code from bash to Python. Mostly done, but not yet committed or pushed.

Need error handling in the labReturn.sh script to rollback changes if it fails.

The conversion code is basically:

1. A bunch of lines, each for a separate file (with path) that need to be converted to PDFs
2. A single line the concatenates the PDF files into a single file
3. A bunch of lines to delete the separate PDF files.

We should be able to list the files (and paths) in a JSON structure, and the let the code do the first part in a loop, build up the concatenation command in the second part, do the third part in a loop.

(I think this is what Stoney wanted to do last year...)