GithubHelp home page GithubHelp logo

Comments (11)

justvanrossum avatar justvanrossum commented on July 19, 2024 1

I managed to rewrite my code so it doesn't rely on typeface.getVariationDesignPosition() anymore, and fontargs.setVariationDesignPosition() works perfectly, so this is no longer a blocking issue for me. Feel free to close or reclassify as feature request.

from skia-python.

kyamagu avatar kyamagu commented on July 19, 2024

Thanks for reproducing this, let's keep this issue open since the fundamental issue isn't yet resolved

from skia-python.

kyamagu avatar kyamagu commented on July 19, 2024

This is likely due to an internal fontconfig issue. Need to check if fontconfig version matters.

from skia-python.

justvanrossum avatar justvanrossum commented on July 19, 2024

FWIW: as of 87.1, this issue persists on Linux, but seems to have been resolved on Win and Mac.

from skia-python.

HinTak avatar HinTak commented on July 19, 2024

Not a fontconfig issue but a freetype issue. According to Skia's c++ source code, this routine has at least 3 different implementations - directwrite, coretext, freetype, being 3 of them... likely freetype too old on the wheel.

from skia-python.

HinTak avatar HinTak commented on July 19, 2024

I think I know exactly why this is broken - if you get the wheel prebuilt skia-python binary from pip, it uses the "locked" freetype version bundled with m87. So until and unless you build skia-python entirely from source, and make it depends on your system's up-to-date freetype (I have such an option in my private fork), or you switch to a much later skia (with a much later Locked freetype version), you are stuck with this bug.

from skia-python.

HinTak avatar HinTak commented on July 19, 2024

The line to change is around

skia_use_system_harfbuzz=false
, and also additional linker flags in the main setup.py. I see the pip-installed skia-python m87 has a private copy of very old freetype (2.8, i think - I dug it up properly and commented elsewhere) rpath'ed in its own private directory under pythonlib.

from skia-python.

HinTak avatar HinTak commented on July 19, 2024

Actually you might be able to fix it in the pip wheel, by patching skia's DEP file, to bundle a different freetype version.

from skia-python.

HinTak avatar HinTak commented on July 19, 2024

Those are relatively new routines in freetype so the version of freetype definitely matters.

from skia-python.

HinTak avatar HinTak commented on July 19, 2024

My system's freetype is up to date but I ended up having to make such a change to make m116 build in CI 8cf897f - this might give you some idea what to do if you want to fix m87.

from skia-python.

HinTak avatar HinTak commented on July 19, 2024

This seems to be fixed with 117bx (and possibly with 116b2) .

from skia-python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.