kyl191 / lr-stash

Lightroom integration with Sta.sh

Hi there 👋

lr-stash's Issues

Utils.getJSON has incomplete error checking

Line ~81 - We catch Lightroom transport errors, but not server errors. Right now if there's a server error, JSON:decode throws an error because we're passing in a table.

Either check for server error, or rework existing error checking to first check for data.status and data.status == "error", then check from Lightroom / server. (2nd one is optimal I think.)

StashAPI is attempting to concatenate a nil value and dying

result.description is nil if there's a server error and JSON is not returned, but StashAPI is still attempting to concatenate the nil value to the error message and dying on that.

Uploading fails if the user's deleted both the stash item and the stash folder

Because error checking dies on the second try, it successfully tries with a blank stash id, but an invalid folder id. Upload dies because the invalid folder id error is the second error.

Fix would probably be to have an extra variable showing a 'fixed' retry that's not counted against the count, to get an extra retry which would allow it to get past the two errors and should upload successfully.

Updating existing image and publishing new image in same process results in overwriting existing photo with a new one

From http://comments.deviantart.com/1/278275666/2511395749:
I noticed the problem when I tried to update an existing photo (I changed the brightness on the photo or something like that) at the same time as publishing a new photo. It got confused and overwrote the existing photo on DA that I wanted to update with the photo that was new. It's done that twice now...