kylehs / kylem-dasmoto Goto Github PK
View Code? Open in Web Editor NEW1st Submitted Project CodeAcademy
1st Submitted Project CodeAcademy
Try to save your images locally instead of adding a link. Saving images adds to the stability of your website because your website is not reliant on the link to be valid all the time. So next time, save all the images under resources/images/
https://github.com/KyleHS/KyleM-Dasmoto/blob/master/DasmotosArts%26Crafts/index.html#L11
Your lines are a bit long right now. Try splitting this into new lines so it's easier to read on one screen without scrolling. Convention is usually ~79 characters per line.
https://github.com/KyleHS/KyleM-Dasmoto/blob/master/DasmotosArts%26Crafts/index.html#L23
Summary Grade: Satisfactory
Good job with your code! I really like the use of indentation and whitespace in your html code! Makes your code very easy to read! Also, good decisions on the classes and ids name. It makes it very clear what its purpose is and makes grouping your sections very effective. These organizational skills come in handy as you expand your code. Great start to the Ready program!
I included a few notes in both the html and css files for you to think more critically about. First, try to save your images locally instead of adding a link. Saving images adds to the stability of your website because your website is not reliant on the link to be valid all the time. Also, make sure to use the html & sign instead of just &, which is &.
This is just a convention. Finally, your lines are a bit long right now. Try splitting this into new lines so it's easier to read on one screen without scrolling. Convention is usually ~79 characters per line.
Next time, make sure to specify your span. For example, do <span class = “prices” >
. This makes your code more flexible as it grows in the future and you have to use span elsewhere. This way you can use it elsewhere if you just specify another class.
https://github.com/KyleHS/KyleM-Dasmoto/blob/master/DasmotosArts%26Crafts/index.html#L13
Use the html & sign instead of just &, which is &
https://github.com/KyleHS/KyleM-Dasmoto/blob/master/DasmotosArts%26Crafts/index.html#L4
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.