GithubHelp home page GithubHelp logo

foundry-vtt-starwars-sagaedition's People

Contributors

cpadilla avatar derinzed avatar jasony1974 avatar kypvalanx avatar talonketupa avatar vertigoogle avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

foundry-vtt-starwars-sagaedition's Issues

Talents: Character is not a member of the null

I don't seem to be able to add Talents. I receive a popup:

You do not meet the prerequisites for this feat:

  • Character is not a member of the null.

It is important to note that sometimes it will add additional reasons for talents I am legitimately not allowed to take.

Talents: Cannot add any talents

I've attempted to make a new multiple different character sheets and with each one, I can't add any talents. When I try to drop a talent in I get "You can't take any more talents of that type", I get this when trying to build out a high level character or a single character with just one level. No matter the class or level, I always get the same message.

I've also tried this with the game paused and unpaused.

Cannot enter data into the Health section

Fields in the health section include "Current", "Temp", "DR" and "SR".
It is not possible to save data into these. Having tried, and exporting the actor, the data on these fields is set to null.

unable to add point-blank shot feat

Tried to add point-blank shot. The character still had one general feat left and one bonus soldier feat.

actor-sheet.js:1415 Uncaught (in promise) TypeError: this.addItemsFromCompendium is not a function
    at SWSEActorSheet.addOptionalRuleFeats (actor-sheet.js:1415)
    at SWSEActorSheet.addFeat (actor-sheet.js:730)
    at async SWSEActorSheet._onDropItem (actor-sheet.js:594)
addOptionalRuleFeats @ actor-sheet.js:1415
addFeat @ actor-sheet.js:730

Armor Ref Bonus are now calculated wrong.

After the latest update, the armor Ref Bonus are now added to the Misc column of the Ref Def; instead of replacing Level, which is the correct method, as in previous version.

Interactions with Equipment revert Actor Form to new form

Hard to describe what happened here but it only seems to occur with items in the Unequipped/Equipped sections.
Moving items between these sections appears to revert the form to that of a new character, but doesn't mess up the character itself.

Conflict with Bulk import audio playlist

When bulk import audio for a playlist, there will be an error. Import the same thing in other game systems work fine.
image

Vanilla foundry with no mod and only with SWSE.

system.json is not updated

Despite the latest release being for Foundry version 0.8.9, the update doesn't get pulled down by foundry clients because system.json still has the wrong values:

  "version": "0.3.6",
  "minimumCoreVersion": "0.7.9",
  "compatibleCoreVersion": "0.7.9",

Without changing the first field, Foundry will not mark the game system as "update available", and even clicking "update" won't pull down the latest version (even if the download field has version 0.4.0 listed). and if compatibleCoreVersion isn't changed, it will always keep the warning for compatibility risks.

It's less a problem for people who install fresh, more of a problem for those who already downloaded the game system and want to upgrade it.

0.2.4 character creation process issues

1). create new character

2). leave attributes at default (10 for all)
Notes:
Character Sheet Warnings displayed: 2
a). PLEASE SELECT A SPECIES!!
b). General Feats remaining: 1

3). add species (Mon Calamari)
Notes:
[comment: Species name does not display, and (Use the Force skill - Can use untrained=Y), but otherwise Summary tab looks correct]
Character Sheet Warnings displayed: 1
a). General Feats remaining: 1
Closed Species compendium

4). add General Feat (Improved Defenses)
Notes:
Character Sheet Warnings displayed: none
Character Sheet Tab status
"Improved Defenses" appears of Feats Tab
Closed Feats compendium

5). add Class (Jedi)
Notes:
Dialog box: On First Level...
Click "OK"
actor-sheet.js:744 pauses on debugger
Click "Resume script execution" in console
Dialog box: Adding Class Starting Feats
Click "OK"
Notes:
Character Sheet Warnings displayed: 2
a). Jedi Talents remaining: 1
b). General Feats remaining: -3
Character Sheet Tab status
Summary Tab
"Trained" checkboxes appear in Skills area
Class Tab
"Jedi" appears with 1 HP
[comment: The +1 HP plus the Con modifier of -1 correctly add to 0 HP on the Summary tab]
[comment: Jedi Class should start with 30 HP, plus con modifier]
Equipment Tab
"Lightsaber" appears in Unequipped area
Feats Tab
"Force Sensitivity"
"Weapon Proficiency"
"Weapon Proficiency"
[comment: General Feats warning count was at 0, and the addition of these 3 new Feats result in the -3]
Closed Class compendium

6). Attempt to Equip Lightsaber
Notes: Clicked & dragged item from unequipped to equipped area.
[comment: Item moves to appropriate area, but Summary tab still indicates unarmed attack.]
Attempted to add lightsaber from equipment compendium to summary tab directly
Created owned item; equipment tab reflected second lightsaber (unequipped)
Deleted duplicate (unequipped) lightsaber from equipment tab
Attempted to drag unarmed attack to equipment compendium, which produced error in console.log
Console.Log Error:
foundry.js:30367 Uncaught (in promise) TypeError: Cannot read property 'getFlag' of null
at Function.fromDropData (foundry.js:30367)
at Compendium._onDrop (foundry.js:28744)
at DragDrop.callback (foundry.js:13525)
at DragDrop._handleDrop (foundry.js:13576)
Closed equipment compendium

7.) Attempted to add Trained Skills
Notes: Attempted to click "Trained" in "Use the Force"
Character Sheet Warnings displayed: 3
a). Too Many Skills Selected: 1
b). Jedi Talents remaining: 1
c). General Feats remaining: -3
[comment: Attempting to add more Trained Skills just increased count of warning; unchecked all but Use the Force; too many skill warning: 1]

8). Attempted to add Talents (Jedi Guardian: Battle Meditation)
Notes:
Console.Log Error:
actor.mjs:130 Uncaught (in promise) TypeError: Cannot read property 'toLowerCase' of undefined
at SWSEActor.getTalents (actor.mjs:130)
at SWSEActor._prepareCharacterData (actor.mjs:41)
at async SWSEActor.prepareData (actor.mjs:25)
Character Sheet fails to render properly:
Summary Tab
All Character Sheet Warnings disappear
All "Trained" checkboxes disappear
HP increases to 10
Condition, Defense, Offense, Attacks, and Abilites sections go blank
Class Tab
goes blank
Equipment Tab
goes blank
Feats Tab
goes blank
Talents Tab
Talent fails to appear.
Closed Talents compendium
Closed Character Sheet
Console.Log Error:
actor.mjs:130 Uncaught (in promise) TypeError: Cannot read property 'toLowerCase' of undefined
at SWSEActor.getTalents (actor.mjs:130)
at SWSEActor._prepareCharacterData (actor.mjs:41)
at async SWSEActor.prepareData (actor.mjs:25)

9). Screen shot of console.log

10). Reopened Character Sheet
Notes: Character Sheet nearly the same as prior to close, except that
new warnings have appeared
Class tab shows Jedi class, but with no HP
Character Sheet Warnings displayed: 2
a). Jedi Talents remaining: 1
b). General Feats remaining: 1
[comment: because no Feats are listed, the character sheet is essentially back to its starting condition]

test character 2 4 - character creation process - console log

test character 2 4 - character creation process - summary tab

test character 2 4 - character creation process - attributes tab

test character 2 4 - character creation process - class tab

test character 2 4 - character creation process - equipment tab

test character 2 4 - character creation process - feats tab

test character 2 4 - character creation process - talents tab

Feats dragged to character sheet do not display until character sheet is closed and reopened

Feats dragged to character sheet do not display until character sheet is closed and reopened. It appears that the feat.bonusFeatCategories property is undefined.

The following error appears in console.log:

actor.mjs:1007 Uncaught (in promise) TypeError: Cannot read property 'length' of undefined
at SWSEActor._reduceProvidedItemsByExistingItems (actor.mjs:1007)
at SWSEActor._prepareCharacterData (actor.mjs:57)
at async SWSEActor.prepareData (actor.mjs:27)

Applying ability point upgrades at lvl 4 clears out all ability scores

Made Actor and populated data. Increased level to 4. Selected attribute placement. Finalized by clicking YES.
Instantly all previously set ability scores disappear. Attempts to set ability scores does nothing henceforth.
Console shows this error afterwards:

Uncaught (in promise) TypeError: Cannot read property 'value' of null
at resolveValueArray (util.js:28)
at generateAttributes (attribute-handler.js:53)
at SWSEActor._prepareCharacterData (actor.js:74)
at async SWSEActor.prepareData (actor.js:34)

Foundry does not launch any worlds using SWSE system

Currently using version 0.3.2
When you attempt to launch the game it gives the following message: "you must define a valid Item type"

After you click the launch button, it also affects your ability to launch other worlds, or the ability to launch updates. Clicking these buttons give the error: "you lack Server Administrator permission to submit this request". Closing and restarting Foundry fixes this.

version 2.3 - feat added bug

version 2.3 does not solve the "Feat added" bug.

Here are the steps I followed:

  1. create new actor - character
  2. set ability scores
  3. add species
  4. add general feat

First screen shot is after step 3, adding the species, the traits for the species are displayed, but the name of the species is not.

After adding the general feat - I used "Improved Defenses" - the Defense, Offense, Attacks, and Abilities sections of the Summary tab are blanked out, the Feat doesn't display on the Feats tab, but the General Feats warning is gone.

If I close & reopen the character sheet, the Feat is displayed, but the sections on the summary tab return to being blank, and the General Feat warning appears again. If I remove the feat, by clicking the trash can icon, the sections on the summary tab repopulate.
test character 2 3 - ability scores added, species chosen
test character 2 3 - general feat added, summary tab data missing

Can't Add Attacks

When I add a weapon to a character sheet from the Compendium, it gives an error and doesn't add the attack.
Capture

Feats not being recognised as class Feats

Attempted to add Rapid-Shot as a Scout Bonus Feat, and Combat Reflexes as a Soldier Bonus Feat, however they are being recognised as General Feats instead.
These Feats do seem to have the appropriate categories listed. Having exported the data, the "supplier" section remains blank, and "isSupplied" remains false. There doesn't appear to be a way to modify this through the interface.

Stabilize Talent System

found in 0.2.4:

8). Attempted to add Talents (Jedi Guardian: Battle Meditation)
Notes:
Console.Log Error:
actor.mjs:130 Uncaught (in promise) TypeError: Cannot read property 'toLowerCase' of undefined
at SWSEActor.getTalents (actor.mjs:130)
at SWSEActor._prepareCharacterData (actor.mjs:41)
at async SWSEActor.prepareData (actor.mjs:25)
Character Sheet fails to render properly:
Summary Tab
All Character Sheet Warnings disappear
All "Trained" checkboxes disappear
HP increases to 10
Condition, Defense, Offense, Attacks, and Abilites sections go blank
Class Tab
goes blank
Equipment Tab
goes blank
Feats Tab
goes blank
Talents Tab
Talent fails to appear.
Closed Talents compendium
Closed Character Sheet
Console.Log Error:
actor.mjs:130 Uncaught (in promise) TypeError: Cannot read property 'toLowerCase' of undefined
at SWSEActor.getTalents (actor.mjs:130)
at SWSEActor._prepareCharacterData (actor.mjs:41)
at async SWSEActor.prepareData (actor.mjs:25)

source #14

Compendium Not Adding Certain Sections

When I make a new world, the Compendium sometimes won't update everything properly. It'll only grab items and classes, or it'll just stop at Feats. If I make a 2nd new world this generally works as intended.

Human Scoundrel get 1 too many feat at level 1

Human Scoundrel should get 2 general feats at level 1, right? Not 3. And they should have +1 trained skill. A human scoundrel with +2 int mod should get 4+2 (int mod) +1 (from being human), but I got only 6

image

Stabilize the Skill system.

found in 0.2.4

7.) Attempted to add Trained Skills
Notes: Attempted to click "Trained" in "Use the Force"
Character Sheet Warnings displayed: 3
a). Too Many Skills Selected: 1
b). Jedi Talents remaining: 1
c). General Feats remaining: -3
[comment: Attempting to add more Trained Skills just increased count of warning; unchecked all but Use the Force; too many skill warning: 1]

source #14

Can't make new actors

So when I create a new actor no character sheet comes up. When I click on the icon or name of the actor nothing happens. Can anyone else reproduce?

Correct Use the Force Skill behavior

  • use the force should be trained only
  • use the force should only be available to be trained if character has a class that provides it and they have the force sensitivity feat

source: #14

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.