GithubHelp home page GithubHelp logo

template-plugin's People

Contributors

hoheps avatar jbleezy avatar l2- avatar mo-pi avatar tylander732 avatar umer-rs avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

template-plugin's Issues

Minor issue with suffix - Runelite related perhaps?

From my testing this is something minor and it might have something to do with Runelite/programming.

The suffix is not saving the (space) in "(space)xp" and when you restart Runelite it changes back to "xp". Not a big deal I retype the (space) in front whenever I open a Runelite and its good to go.

[FEATURE REQUEST] Support for colored max hits

Add an option for "Xp drop color max" underneath the "Xp drop color range" option.

With this option, whenever you hit your maximum hit in your currently equipped gear (offensive prayers such as piety and rigour included in calculation), the color of the xp drop would show up differently to quickly indicate to the player that they have gotten a max hit.

It's not much, but I have however included the code for how I think the XpDropsConfig.java file would change.

@ConfigItem(
	keyName = "xpDropColorMax",
	name = "Xp drop color max",
	description = "Color of the XP drop text when hitting your max hit",
	position = 11,
	section = xp_drop_settings
)
default Color xpDropColorMax()
{
	return Color.WHITE;
}

Some special cases to consider would be things such as salve amulet against undead creatures, dragon hunter weapons against Vorkath, Olm, etc.. and some other niche cases probably exist im sure. I would try to implement this myself and send a push request, but I'm not sure how to calculate the max possible hit of someone's current gear.

empty spaces in prefix/suffix cleared after session

I've been adding blank spaces to the prefix and suffix to make the xp drops text a little more spaced out. It works great but after closing runelite and reopening it will truncate all the empty spaces and only leave the normal text that I had in the prefix/suffix boxes. I am trying the blank space character (ALT + 255 "ย ") and will let you know if that also gets removed

Slow Xp Drops

The xp drops were speeding up when I first installed them and now they are slowing down way slower than what I have them after tweaking them for awhile. They were perfect for couple hours and now are super slow for some reason.

XP drops don't split

Unless I am missing an option somewhere, it would be nice if there was a way to split the XP drops when training multiple skills simultaneously as opposed to simply adding them up into one number.

Plugin
XP Plugin
Default
XP Default
.

Longrange attack style incorrect recolour

Hi,

Currently, when you attack with a magic or ranged weapon on Longrange while praying melee offensive prayers (piety etc.), it will recolour the xp drop to the melee offensive prayer colour (I assume because of the defence XP). This doesn't happen on non-longrange styles. I think it should default back to the default colour when this happens, like it does on accurate and rapid attack styles.

Importing Font box

image
Is this "font" option box used for importing your own fonts? Does it take .ttf? Where would you navigate to put a font in if that is the case?

Suggestion: "Hide XP drops" option for people using Hit Prediction

The XP drop becomes redundant screen clutter when pking and using hit prediction, could we possibly have an option to hide XP drops when using hit prediction? I tried setting time until disappear to 0, but this still caused it to flash occasionally, which was distracting.

Thanks again, amazing plugin.

"<col=ffffff>" appended to front of string on an XP drop

been doing my farm runs for a while when I noticed this text being appended to the xp drop, its not the text color though as any changes to that do not reflect to the appended text:
kSQx2RkDC6
i have not made any changes to the plugins settings nor have I installed any plugins on RL that may conflict with this plugin. resetting RL does not make this issue go away either
and in case you want to know: here are my settings.
CKmK03lsgg
k5lje6DRDK

Suggestion - "+" and "xp"

FINALLY Awesome plugin! Been waiting for ever for someone to make this.

Can you add an option to add a "+" instead of skill icon in front of the number and a "space" followed by "xp" at the end of the drop?

So it would be "+(xpdrop) xp"
Example - https://streamable.com/u8ppz

I am trying to get my xp drops to pre eoc xp drops as they look aesthetic.

Rapid attacks and predicted hits cause text overlap

image

This is with the following settings: (And using darts on rapid)

  • Group XP Drops: false
  • XP drop delay: 25
  • Vertical XP drop speed: 25
  • Time until disappear: 150
  • Show predicted hit: true

I've played around with the timings of all relevant settings and I cannot find a good way to avoid this issue. When the hits are spaced out this is not an issue, only after 3+ consecutive hits do the numbers start severely overlapping as shown. It seems to be a specific issue with predicted hits as the XP drops don't overlap with each other, only the predicted hit and XP overlap with each other.

Filtered skill doesn't stick

I have the plugin set to hide hitpoints. When I relaunch the client, the hitpoints reappear. I have to go into "Skills to filter" and press enter every time to get hitpoints to hide agian.

Grouped and un-grouped

when you have the plug-in set to separate xp drops the xp drops overlap each other and cant make out what the drop is. when you group the xp drops its fine

Ungrouped Predicted Damage

Hi, I've been enojoying using your customizable XP drops plugin to show predicted damage but the way predicted damage is displayed for ungrouped XP drops feels awkwardly placed.

Would it be possible to add an option to have ungrouped XP drops displayed like this?

Predicted hit always white unless overridden

Idk if I'm missing something, after the recent fix to the <col #####> now my predicted hit text is always white unless overrridden. Previously it would adopt your base XP drop colours/active prayer colours

Offsets from player

Could you add the ability to configure a position offset when attached to the player?

Predicted hit filter option

Would it be possible to add an option filters the predicted hit based on what style you are using? I would like to hide the predicted hit ffor melee since its almost always pretty instant anyway, however it would be nice to have it so the predicted hit shows up for magic and ranged since they have a potentially long delay.

Suggestion: Add a "Group Combat XP drops only"

Currently the option to group xp drops is all or nothing, so if I want to group up all 4 xp drops from using DHL I also need to group the wc/fm drops when skilling with infernal axe.
I'd like the "Group XP Drop" setting to be changed from a checkbox to a picklist between "All, combat only or skills only"

Xp drops overlap when receiving slayer xp

I noticed that when killing a slayer monster on a task the slayer XP drop overlaps combat XP drop making it hard to read. I think that there is an easy solution to fix this.

Scenario:
CUK9S3w

These are my settings on the plugin if there is something to do with them:
TT8vOdI

Predicted hit text not being colored when combat skills are filtered in the xp drop settings

This is a small, dumb and very niche issue, but it just gets the best of me due to my OCD.

I love the predicted hit feature. The main use for combat xp drops for me was to know when I was gonna land a hit.
Now I know when I'm gonna land a hit, and 99.9% of the time I know how much exactly it will hit.

The only problem is I don't like the clutter of predicted hit + skill xp drops, so I filtered out the xp drops for combat stats.

However, this had the side effect of not coloring the predicted hit based on which combat style I'm hitting anymore.

I would love to be able to filter out combat stats xp drops, have predicted hit on and have it be recolored based on the combat style I'm using.

This would also help me know when I've correctly got my boosting prayers on, or when I accidentally forget to turn them on after they've been disabled.

I thought I might give it a shot and create a request.

Below are some images to further clarify.

image

image

Font doesnt change

I've typed BankGothic to the font box and it doesnt change. Any ideas whats wrong?

Allow xp drops while hiding xp drops in game settings

So it looks like v1.5.4 of the plugin made it so that Hide XP drops in game makes this plugin hide XP drops.

I liked the behavior prior to this version where I used Hide XP drops in game to hide the progress bar, but used this plugin to show the XP drops anyway.

Can we add an option to always show XP drops no matter what the game setting is?

Suggestion

i didnt know where i could put a suggestion.

could you add a feature to convert the combat xp drop to the amount of damage the hit is going to deal?

Feature Request: Change xp drop location based on attack style

When config.attachToTarget is true, the xp drops will be attached to the players target while in combat. I like to enable this setting because it subjectively feels like that's where the xp drops should be displayed. However, I find it kind of strange to not have the xp drops not near the center of the screen when in ranged (not melee) combat.

I'd like to propose a similar setting that checks the selected attack style and uses that information to determine where to display the xp drop. If the player has a melee style selected, attach the drops to the target, otherwise attach it to the player.

I'd be happy to put in a PR for this myself but wanted to gauge opinions beforehand. Thanks for your input!

the plugin doesnt work at all

hey, i was wondering if there is any issue with the plugin? today its just stopped working tried turning it off and on and it didnt change anything,normal xp drops works tho

StringIndexOutOfBoundsException

2022-10-23 09:05:29 [Client] WARN n.r.c.ui.overlay.OverlayRenderer - Error during overlay rendering
java.lang.StringIndexOutOfBoundsException: begin 0, end -1, length 1
at java.base/java.lang.String.checkBoundsBeginEnd(Unknown Source)
at java.base/java.lang.String.substring(Unknown Source)
at com.xpdrops.overlay.TextComponentWithAlpha.render(TextComponentWithAlpha.java:63)
at com.xpdrops.overlay.XpDropOverlayUtilities.drawText(XpDropOverlayUtilities.java:192)
at com.xpdrops.overlay.XpDropOverlay.drawXpDrops(XpDropOverlay.java:96)
at com.xpdrops.overlay.XpDropOverlay.render(XpDropOverlay.java:40)
at net.runelite.client.ui.overlay.OverlayRenderer.safeRender(OverlayRenderer.java:719)
at net.runelite.client.ui.overlay.OverlayRenderer.renderOverlays(OverlayRenderer.java:322)
at net.runelite.client.ui.overlay.OverlayRenderer.renderAfterInterface(OverlayRenderer.java:236)
at net.runelite.client.callback.Hooks.drawInterface(Hooks.java:522)
at client.ov(client.java:541)
at jd.jk(jd.java:10789)
at ao.jn(ao.java:10296)
at client.ho(client.java:4495)
at client.av(client.java:1215)
at ae.aj(ae.java:415)
at ae.run(ae.java:369)
at java.base/java.lang.Thread.run(Unknown Source)

can't replace xp drops

currently, both XP drops and damage are displayed. is it possible to add a feature that replaces the XP drop with the damage, similar to what the instantdamagecalculator plugin does

df89117cfd7dec686acdc2640d884871.mp4

?

Hit prediction & filtering

Such a great plugin, but found a small issue, filtering hitpoints breaks hit prediction.
Keep up the great work ๐Ÿ‘

Feature Request: Allow us to change the color of the xp drop for combat skills affected by prayer boosts (like XP Drops plugin)

Just want to say this plugin is fantastic and you've done great work OP. You fixed that last bug really fast and I respect you for that. Since I know you're alive, I thought I might as well just post this request since it's something I find would be really useful for those learning to 1-flick prayers

The other XP Drops plugin (doesn't allow customization to the same level as yours) has the ability to change the color of the xp drop when the attack is affected by a prayer boost, can you add this option here as well? That way I don't have to switch to the other plugin if I'm trying to practice flicking. Thanks

I may take a stab at implementing myself but I'm not sure, never worked on a runelite plugin before

SUGGESTION: Customizable prefix/suffix for predicted hits

Hey! Love the plugin! I've been using it for a while and had no issues so far until I turned on predicted hits and noticed that it shared the same custom prefix/suffix as the XP drops. This makes it a bit weird as seen on the provided screenshot. Is there any possibilities to implement a custom prefix/suffix system like the XP drops, but for the predicted hits?

Thanks!

predicted_hit

Stacked ungrouped XP drops

With "Group XP drops" disabled, XP drops stack on top of each other on the z-axis instead of the x-axis or y-axis when experience is ganed in multiple skills at once.

Observing the same behaviour with "Attach to target" disabled.

Config for reference:

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.