Better support for notifications about labwc

[johanmalm]

I've been able to reproduce.

The notifications must be WLR_XDG_SURFACE_TOP_LEVEL (https://github.com/johanmalm/labwc/blob/a67e74670b581a8abbd7542a3c41f97a721e89f1/src/xdg.c#L387)

And we center WLR_XDG_SURFACE_TOP_LEVEL surfaces which are not topmost (i.e. have a parent)
https://github.com/johanmalm/labwc/blob/a67e74670b581a8abbd7542a3c41f97a721e89f1/src/xdg.c#L285

Something obviously isn't quite right. Need to investigate.

I've not used Thunderbird for a long time, but it looks very GTK3ish, so am pretty sure it's Wayland. Also, the alt-tab dialog shows it's xdg-shell. Or did I misunderstand your xeyes note.

[Joshua-Ashton]

Yeah, I was not aware of it showing in alt-tab. Typically on other compositors, a good way of testing if Wayland vs XWayland is to use Xeyes. If the eyes move, the window is XWayland, if they stop, it's Wayland.

[johanmalm]

The thunderbird notification is a WLR_XDG_SURFACE_TOP_LEVEL and doesn't seem to have a parent. Not sure how to deal with this one. Help needed.

It could possibly be because we aren't handling the toplevel's set_parent event. However, if this problem doesn't occur in Sway, then that isn't likely to be the case. Sway doesn't handle set_parent events either.
Not sure how useful this may be, but this makes me think of sevz17/dwl@57f4d64. In that case, a client's parent was found using their process ids.

[Joshua-Ashton]

The notifications should appear without ssd and in the bottom right corner of the screen. They shouldnt be parented I think. This works in plasma and gnome wayland

[emersion]

Typically notifications on GNOME/KDE go through the org.freedesktop.Notifications D-Bus API. There exists layer-shell clients that implement this API, e.g. mako.

[Joshua-Ashton]

Tested it, and it does use a native notifications thing on KDE, yeah. Thanks for the tip! :)

[Joshua-Ashton]

Installing mako fixed the problem.

[johanmalm]

I've just installed mako + rebooted, but still get the notification with SSD in the middle of the screen.
I tried with sway yesterday without mako, and interestingly it knows not to draw the blue titlebar and positions it in the bottom right (although on a different output).

Maybe you could check out emersion/mako#126?

[johanmalm]

Maybe you could check out emersion/mako#126?

Thanks @ARDiDo . I've got libnotify installed. Have tried disabling/enabling alerts in Thunderbird. Will have to carry out trying tomorrow.

[Joshua-Ashton]

I had to start mako in my autostart script fwiw

[johanmalm]

Thanks @Joshua-Ashton
Yes, starting mako helps 😄
I thought I had sorted it with systemctl enable mako, but obviously not.