lambdaisland / dom-types Goto Github PK

When pretty-printing a DOM tree, cljs.pprint/pprint's output not being formatted on multiple lines.

Seen in the REPL of Intellij/Cursive.

I would like to add DOMStringMap type to the list. It comes up when accessing data-* attributes of an Element and would be useful for inspection. Is it okay to make a pull request?

note: I'm new to open source contributing but I read lambdaisland/open source README , CONTRIBUTING section and took an overview of the code. I think I can manage to help and maybe add section on usage for how to use the library.

About this line:

(register-printer js/DocumentFragment 'js/DocumentFragment #(map hiccupize (.-children %)))

The laziness of the returned sequence means that if the output value is not eagerly consumed in a timely manner, the value might not be consistent with the state of the DOM at a given point in time, because the DOM can be mutated.

To be safe, I suggest to change it to:

(register-printer js/DocumentFragment 'js/DocumentFragment #(seq (mapv hiccupize (.-children %))))

Printing this element causes an exception in hiccupize

<!-- [if IE]><script src="http://html5shiv.googlecode.com/svn/trunk/html5.js"></script><![endif] -->