lambrohan / nestjs-meilisearch Goto Github PK

Currently, the module uses meilisearch as a dependency, and at version 0.20.1.

Each meilisearch's version is tied to a specific server version.
Using a client version incompatible with server version will cause incompatibilities and may lead to unrecoverable application errors.

The module's user should be able to use any meilisearch version to match with its server implementation.

I also suggest to add meilisearch as dev dependency for module development.

Document type has been removed from meilisearch JS codebase in this PR.

We have this error when running the module.

Module '"meilisearch"' has no exported member 'Document'

Workaround in package.json:

"meilisearch": "^0.30.0",
"nestjs-meilisearch": "^2.1.2",

Would it be possible to investigate adding peer dep support for Nest 9 for the nest/common package?

Currently, this module does not support async registration.

Async registration would be useful for getting configuration variables from ConfigModule, among many other use cases.

We should be able to register the module like this:

MeiliSearchModule.forRootAsync({
  imports: [ConfigModule],
  inject: [ConfigService],
  useFactory: (configService: ConfigService) => ({
    host: configService.get<string>('MEILISEARCH_HOST'),
    apiKey: configService.get<string>('MEILISEARCH_API_KEY'),
  }),
}),

@lambrohan you're sure the release is good ? I got some errors : Cannot find module 'nestjs-meilisearch' or its corresponding type declarations.
Meanwhile I fixed it with an npm run build inside the node_module but now it's time to CI :P

Originally posted by @jclappiway in #8 (comment)