langermank / jammming

code academy

Hello! I'm Katie

I'm a Systems Designer at GitHub working on Primer

Living in San Diego 🌴

I watch a lot of movies, TV series and British panel shows

Talk to me about CSS, design and front-end development on Twitter @KatieLangerman

jammming's Issues

Code Structure

Good job on keeping consistent with your indentations and whitespace as this made for a organized code structure that was easy to navigate through.

Don't forget that you can place tag attributes each on their own line if they venture too far off to the right. This will make for a list like code structure that assists with legibility.

https://github.com/langermank/jammming/blob/master/src/Components/TrackList/TrackList.js#L12

Summary

This was a well written project and it shows through the flawless functionality of your Jammming project.

++ Consistency with indentations and whitespace.
++ Sound code logic.
++ Live search function.
++ All necessary functionalities present.

-- Addition of comments would've been nice.

Overall, an amazing job on this project! Keep it up!

Grade: Exceeds expectation!

Live Search Function

Loved the live search function you implemented!
This is a great example of the advantages that come with using React.
Although it's just a simple tweak that changes the boring "click search" functionality to a more responsive "search while you type" option, it makes a world of a difference in terms of user experience!

Console Messages

I noticed while I was interacting with your project I was getting a lot of console messages regarding unused variables, bad requests, and keyless children.

Although it isn't too big of a deal, it would be a good idea to have these taken care of as they make for a cleaner application.

Feature Request

Grade: Meets expectations

Summary:

Wow I love the screenshots and detail with which you explained your concept.

The addition of the search when pressing enter is a great feature. Initially, when I was reviewing Codecademy's example app, I was surprised to see that pressing enter doesn't allow the search to move through.

You lay out a rock solid plan for implementing a feature that definitely improves the user’s Jammming experience. The idea itself is a natural suggestion, as most users would likely assume the Enter key would serve that purpose and therefore would find it inconvenient that the app doesn’t do that. Your implementation is also the easiest way to accomplish the goal.

I thought the technical design was outstanding with visual cues and detailed instructions on implementation. Caveats were well thought out. Nice work!

Re: the technical design, you could also have a conditional statement within the search method so that the search is only sent when the search box is filled :) We don't want to accidentally trigger a search if it is empty.