lardeck / improvedtalentloadouts Goto Github PK

I've had this issue where when i import a loadout from say, wowhead, and then import it, i have manually add all the talents and its giving me the message when i try to activate the loadout:

"[TalentLoadouts] Can't load Loadout. You must spend all available talent points to apply changes"

And adding that same string into the default blizzard loadout or Talent Tree Viewer, its working normally. Some strings "doesn't work" and some work like they should. Not getting any error either.

When clicking on a Loadout while "Automatically apply Loadout" is enabled, the "Apply changes" button incorrectly stays active while channeling and after the channel ends. Ideally, it should gray out as soon as the channel for switching Loadout starts.

When renaming a Category or Loadout, even if we only want to change a single letter, we have to write the whole string because the text field is empty, not pre-filled with the previous name.

When loading Action Bars, if a slot is supposed to go from full to empty, it doesn't. Instead, it stays the same.

When I delete or change Build using the Blizzard menu, the addon menu isn't affected.

I'm getting this error for a while now and can't find the cause.
It won't even show the dropdown or the spec buttons on multiple characters.

25x ...ns/ImprovedTalentLoadouts/ImprovedTalentLoadouts.lua:156: attempt to concatenate local 'realm' (a nil value)
[string "@ImprovedTalentLoadouts/ImprovedTalentLoadouts.lua"]:156: in function <...ns/ImprovedTalentLoadouts/ImprovedTalentLoadouts.lua:154>
[string "@ImprovedTalentLoadouts/ImprovedTalentLoadouts.lua"]:214: in function CheckDBIntegrity' [string "@ImprovedTalentLoadouts/ImprovedTalentLoadouts.lua"]:338: in function InitializeTalentLoadouts'
[string "@ImprovedTalentLoadouts/ImprovedTalentLoadouts.lua"]:108: in function <...ns/ImprovedTalentLoadouts/ImprovedTalentLoadouts.lua:102>

Locals:
name = "Malphaas"
realm = nil
(*temporary) = "Malphaas"
(*temporary) = "-"
(*temporary) = nil
(*temporary) = "attempt to concatenate local 'realm' (a nil value)"

This functionality would help when transitioning between PVE -> PVP which often have very different UI requirements.

I'm not sure how feasible this is, but using C_EditMode.GetLayouts() and C_EditMode.SetActiveLayout it seems like it would be possible.

It would be nice to have an option to switch from Specialization names to icons. In some languages the names are being cut off due to being too long. Specialization icons don't have that problem, take less space (particularly useful for Druids as they have 4 Specializations), and look nice.

I recommend some friends use ImprovedTalentLoadouts, but some of them are not good in english.

seems no localization file yet, if plan for this, i can support zhTW/zhCN.

After deleting all Blizzard Builds for a given Specialization, Builds for another Specialization appeared in the addon menu.

I feel like Categories occasionally change order out of nowhere. It would be nice to be able to sort Categories in alphabetical or, even better, custom order.

When I switch Loadout, the icons on my Action Bars stay the same, even if clicked Save Action Bars.