larshollingsed / 06-23-catering

Catering Finance Manager

The catering finance manager helps keep track of employees' wages.

For example - I have 5 employees in my company. In the last week my company has catered 8 events. Each event has one employee as the manager and at least one other employee. Given that each event has its own length of time, base hourly pay, and possibly a gratuity (to be split), I want to be able to write each employee their checks at the end of a week. I also want to make sure that I didn't make any errors such as paying two people to manage one event.

Description

employees table

• • id (primary key)
• • name (text)
• • age (integer)

events table

• • id (primary key)
• • date (text?)
• • length (number)
• • hourly pay (number)
• • gratuity (number)
• • serving alcohol? (boolean)

distributions table

• • id (primary key)
• • employee_id (foreign key)
• • event_id (foreign key)
• • manager? (boolean)

What we should be able to do

• • add an employee
• • delete an employee
• • modify an employee
• • add an event
• • delete an event
• • modify an event
• • attach one or many events to one or many employees
• • calculate how much an employee earned (possibly over a given time period)
• • calculate how many hours an employee worked (possibly over a given time period)

What we should not be able to do

• • add an employee who is under 19 to an alcohol serving event
• • have more than one manager attached to a event
• • split tips with a manager

06-23-catering's Issues

Delete an event

Delete an employee

Calculate how much an employee has earned

Possibly over a certain time period

Attach one or many employees to one or many events

models and tables

Tables -

employees table

id (primary key)	name (text)	age (integer)
1	April	33
2	Jarad	35
3	Lars	18

events table

id (primary key)	date (text)	hours (number)	hourly_wage (number)	gratuity (number)	alcohol (text)
1	06-11	5.5	10.50	30	true
2	06-12	7	9.75	50	true
3	06-13	4	15.00	0	false

distributions table

id (primary key)	employee_id (foreign key)	event_id (foreign key)	manager (text)
1	1	1	true
2	1	2	false
3	2	1	false
4	3	1	false

Add an event

Don't allow more than one manager to be paid per event

Add an employee

Calculate how many hours an employee has worked

Possibly over a given time period

Don't allow an employee to split tips when working as manager

Modify an event

Modify an employee

Don't allow an underage employee to be paid for an event with alcohol

Refactoring

• Did you mean to specify Product here? https://github.com/larshollingsed/06-23-catering/blob/master/database_instance_methods.rb#L15 That makes it less universal than it could be.
• Repeated code could be DRYer: https://github.com/larshollingsed/06-23-catering/blob/master/database_instance_methods.rb#L8
• https://github.com/larshollingsed/06-23-catering/blob/master/database_instance_methods.rb#L21-L47 should be split into smaller methods. (If not for DRY purposes, then for SRP purposes.)
• https://github.com/larshollingsed/06-23-catering/blob/master/database_methods.rb#L12-L15 - repeated process could be DRYed up.
• Repeated code: https://github.com/larshollingsed/06-23-catering/blob/master/database_methods.rb#L22
• https://github.com/larshollingsed/06-23-catering/blob/master/database_methods.rb#L36-L57 - should be split into smaller methods. (If not for DRY purposes, then for SRP purposes.)
• Use reader methods instead of accessing @ variables directly. https://github.com/larshollingsed/06-23-catering/blob/master/models/events.rb
• Documentation
• Indentation - https://github.com/larshollingsed/06-23-catering/blob/master/models/events.rb#L61-L62
• There is SQL querying 'distributions' in your non-Distribution models. That SQL should be in a method in the Distribution model instead, and your non-Distribution models should use those method.