GithubHelp home page GithubHelp logo

Comments (4)

larshp avatar larshp commented on July 17, 2024

looks like it default checks for 4 sequential blank lines? https://github.com/larshp/abapOpenChecks/blob/main/src/checks/zcl_aoc_check_13.clas.abap#L80

If its not possible to enforce 1(assuming you have configured it), then change it to 2.

maybe even open an issue for https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#add-a-single-blank-line-to-separate-things-but-not-more in clean-abap, as the editor supported by SAP cannot follow the styleguide

from abapopenchecks.

sellchris avatar sellchris commented on July 17, 2024

In my system MV_LINES is 2 in method check. Not sure where 4 is overwritten. The question to me is if the max empty lines should be applied to EACH part of the class separately, or not?

from abapopenchecks.

larshp avatar larshp commented on July 17, 2024

if the reason for applying the check is readability, the readability is for what is shown, the full class is shown in ADT

but anyhow, an additional setting for having the rule to run for each part is welcome in a pull request

from abapopenchecks.

sellchris avatar sellchris commented on July 17, 2024

The full class is shown in the ADT. But a class is stored in different parts:

E.g.:
CL_========CP
CL_
========CCDEF
CL_========CU
CL_
========CO
CL_========CI
CL_
========CCMAC
CL_========CCIMP
CL_
========CCAU
CL_=======CM001
CL_
========CM002

I am not sure how to add a new setting in the framework. Just wanted to get rid of this warning :-).

from abapopenchecks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.