Comments (18)
I suspect the problem comes from the defined error code-number "003" in the constructor and the passed code-number in "inform" (001).
Can you try to make "003" into "001" in the constructor at "insert_scimessage"?
from abapopenchecks.
guess something changed in the abapdoc api, try setting a breakpoint
from abapopenchecks.
The check successfully reaches method INFORM
with the following text in p_param_1
:
inconsistency ABAP Doc comment - parameter interface of element EXAMPLE
So it doesn't seem like this is a problem with the abap Doc API to me. Any other ideas?
from abapopenchecks.
This is the result now:
I think we're on the right path, but we're not quite there yet. Any chance we can exchange the very generic message for a more specific message? The more specific message can only be seen in SAP GUI:
from abapopenchecks.
Ok, step by step a little further. :-)
Unfortunately, I can't test it. But what can be seen in the Detail view?
from abapopenchecks.
The detail view looks good:
Compared to before:
from abapopenchecks.
A PR is welcome. :-)
from abapopenchecks.
I didn't submit a pull request because I'm not happy yet with how the text turns out. Compare it to check 001 for example:
How can this text be changed? I tried to change iv_text
like this, but it had no effect:
insert_scimessage(
iv_code = '001'
iv_text = 'ABAP Doc parameter name is inconsistent' ).
from abapopenchecks.
What is your goal? To change the highlighted text in the screenshot?
This text is from the class description; the check-title.
from abapopenchecks.
I want to change the other text 😊
from abapopenchecks.
I had now also the possibility to test this with eclipse. For me the result looks like this (with the latest PR):
from abapopenchecks.
That's weird! I'll check the installation and report back. (Could take a while, I'm having some authorization problems right now...)
from abapopenchecks.
My authorization problems are fixed and I'm running the latest version now. The message still isn't displayed correctly.
Can anyone please re-open this issue?
I also tried it using SAP GUI, same result:
from abapopenchecks.
Is it ok to change the text of the check message from "&1" to "ABAP Doc: &1"?
This would then look like this:
For the findings list, the text of the check message is used; however, the variables are replaced by "..." and only added later, e.g. in the details.
from abapopenchecks.
Are we still talking about the same problem? I'd be actually okay with the way it already works in your previous screenshots, it just doesn't seem to work on my system. 😅
- On your system:
inconsistency ABAP Doc comment - parameter interface of [...]
(cut off in the screenshot)
- On my system:
Check: ZCL_AOC_CHECK_63, Rule: 001
from abapopenchecks.
Right, so I have a bit more experience with ATC checks now and I think I know what's going on now.
- The ATC check message is only defined with a message variable:
&1
- The actual text (
inconsistency ABAP Doc comment - parameter interface [...]
) is put into the message variable when calling methodINFORM
- For some reason, the behavior of MiLiCLN's system is different to mine: On his system, ADT already shows the complete message. On my system, it shows
Check: ZCL_AOC_CHECK_63, Rule: 001
- I conclude that my system replaces the complete message text with
Check: ZCL_AOC_CHECK_63, Rule: 001
if it only consists of a single message variable. If I include any other text in the message, then it works as expected.
I'll provide a pull request to fix this.
from abapopenchecks.
I've changed the message from &1
to ABAP Doc: &1
and it works in the SAP GUI:
However, it doesn't work in ADT:
If I change the error code from '001'
to '002'
(both in the constructor
and in the run
method), then it works in ADT too:
Restarting my own PC didn't help, and it also behaves the same for colleagues. Maybe there is some kind of additional caching for the ATC message check? I'll keep an eye on it.
from abapopenchecks.
Maybe there is some kind of additional caching for the ATC message check? I'll keep an eye on it.
I suspect that this was the case. The error message is correctly displayed for '001'
now.
from abapopenchecks.
Related Issues (20)
- CHECK outside of loop (CHECK 02) should be more smart HOT 1
- Wish: Enforce "new" SQL syntax (e.g. by requiring FIELDS keyword) HOT 2
- ZCL_AOC_CHECK_13: Wrong warning message? HOT 4
- Check 64 - CX_SY_DYN_CALL_ILLEGAL_METHOD HOT 1
- CHECK_69: Missing FM IDOC-Signature for Output
- Error: Pretty printer settings do not match HOT 4
- CHECK_59: IF object IS NOT INSTANCE OF class - abapOpenChecks boolean parser error
- CHECK_83: Reference of DDIC object not found in function module signature HOT 2
- New check: Check if dynamic exceptions are ignored HOT 2
- DownPort Syntax expanding nested tables HOT 2
- Check 59 : condition with corresponding #( )
- Using `ZCL_AOC_SUPER` vs. `ZCL_AOC_SUPER_ROOT` HOT 2
- Feature request for `zaoc_open_transport` HOT 1
- Change request: `zaoc_open_transport` , incompatible with background jobs HOT 1
- New Check: ATC for using selects over the tables with replacement object (like MARC) HOT 11
- Add scorecard as badge HOT 1
- Check 103: Unit test fails when quickfix method doesn't exist HOT 5
- feature idea: equal WHEN statements in CASE HOT 2
- Check 47: false positive for obsolete statements
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abapopenchecks.