larsvansoest / emote-clue-items Goto Github PK

After the new OSRS inventory updates, the margins of the overlay seem to have moved a little.

The icon of the emote clue now jumps a few pixels back and forth when opening and closing the bank.

I know the plugin name itself says EMOTE Clue Items, but I had hi alched my D Scim because I thought there is 0% chance I'm going to need it (after receiving the whip). There is an Elite clue skill challenge to equip Dragon Scimitar. I rememer there being other like this too but they were easy and/or easily obtainable, now 100k for D scim that's it

Bush

Outside the Seers' Village courthouse

Adamant halberd • Mystic robe bottom • Diamond ring

Related to #41

Integrate GIM group storage in progress manager.

2021-10-21 17:11:56 [Client] WARN n.runelite.client.eventbus.EventBus - Uncaught exception in event subscriber
java.lang.ArrayIndexOutOfBoundsException: Index 13 out of bounds for length 13
at com.larsvansoest.runelite.clueitems.progress.ItemTracker.writeDeltas(ItemTracker.java:62)
at com.larsvansoest.runelite.clueitems.progress.InventoryMonitor.fetchEmoteClueItemChanges(InventoryMonitor.java:74)
at com.larsvansoest.runelite.clueitems.progress.ProgressManager.processInventoryChanges(ProgressManager.java:110)
at com.larsvansoest.runelite.clueitems.EmoteClueItemsPlugin.onItemContainerChanged(EmoteClueItemsPlugin.java:189)
at net.runelite.client.eventbus.EventBus$Subscriber.invoke(EventBus.java:70)
at net.runelite.client.eventbus.EventBus.post(EventBus.java:220)
at net.runelite.client.util.DeferredEventBus.replay(DeferredEventBus.java:69)
at net.runelite.client.callback.Hooks.clientMainLoop(Hooks.java:189)
at client.draw(Client.java:1563)
at client.ad(Client.java)
at ay.h(GameEngine.java:390)
at ay.run(GameEngine.java:344)
at java.base/java.lang.Thread.run(Thread.java:834)

I noticed the Tzhaar-ket-om is not tagged for Master clues, I had this as a Master clue step to show Falo the Bard this item.

When a new item is added to the collection log, create a second chat message if that item is a clue emote item.

By hooking into the collection log notification system Runescape already uses, this would work with both clue rewards and PvM activities.

Feature as suggested here: runelite/runelite#14848 (comment)

The user should not be spammed with the notification again after opening it.

Right now, it shows after each update.

Several clue scroll rewards are used in other emote clue steps. Highlight items in the reward screen of clue scrolls would let ironmen know which rewards to save.

This is an alternative to #34 that might be easier to implement. It also doesn't rely on the player having collection log notifications enabled.

Inventory is always available, so this should not be included in the notification.

Why doesn't the plugin automatically check off the stashes when done? I had to manually click one as filled. https://i.imgur.com/4t14w1S.png I checked it to make sure. I have to click the box to make it green instead of the white box on the side panel for the plugin.

Include STASH units in the item collection log.

Add a tab to view stash-progress separately.

Then, add config option to disable overlay for already stashed items

When I put my addy armor into the stash for the medium clue step it gets marked in the plugin as missing

Hey, I had this plugin installed but it suddenly disappeared from my installed plugin list. I cannot find it on the plugin hub either. Has it been removed?

Thanks

I'm not sure if it's an issue on my end, but when I log in to RuneLite my built stashes are all marked as built but unfilled. A couple times I have gone through and checked them all off as filled, but it would be much easier with an option to mark all built stashes as filled.

The issue could be related to my having two different OSRS accounts with different RuneLite accounts/folders? It's possible I didn't set that up correctly but I followed the directions indicated by RuneLite.

Either way, this is one of my favorite plugins! Thank you so much!

the Stash unit Ardougne Zoo Parrots is incorrectly spelled as Aroudgne Zoo Parrots

(sorry if this is not normally how issues are reported, made an account on github to report this after accidentally coming across this)

Title - the plugin was removed from runelite. Cannot find it in the plugin hub anymore.

I am using this to see what items I can safely alc as an ironman, to prevent having to grind them later for clue steps. But the items like swords and armor that are purchasable in shops, I would like to be able to filter them. Is this already possible, or a possible addition?
tyvm for the plugin so far

Title self explanitory, the latest update broke Emote Clue Items

RuneLite
BOT
— Today at 12:16 PM
Some hub plugins failed to build against the latest RuneLite version, this means that they're not available until the owner updates them.

As a user, I would like to be able to view a stashunit on the map. So, the ui must contain some button that leads to it.

The image shows a rough sketch.

As a user, after clicking the button of #65, I would like there to be some pointer on the map that guides the way to the stashunit. Similar to the emote clue and quest helper plugin, their should be a symbol on the map and an arrow in-game pointing to it.

Turning the plugin off through the settings and turning it on again seems to result in all stashunit panels not being turned off.

As title suggests.

IGN Broweritij came with the idea to add the emote clue items overlay to the GIM group storage aswell.

I don't think the tracking is working with multiple accounts. The items are marked as if they're not in stash units.

Can you make it possible to disable clue marking for certain tiers? i only do master clues, so i don't want all the marking on say easy clue items

After logout, STASHUnits builds are still visible in the ui. Ideally, the ui would be entirely cleared after logout.

This bug is only visual, and resets as soon as the user logs back in and opens his bank. Therefore, this issue does not interfere with the user experience.

Title, can't begin progression because of my account type, would still be very useful for UIM too :D

i filled the stash unit that needed rune platelegs and when I go to my bank it says I still need it for stashes.

@larsvansoest

A lot of the new features lack proper documentation.

As mentioned here, runelite/plugin-hub#2586 (comment).

The config groups should be moved to a unique key. While I am at it, I will also change the format of other config keys/values to match a more future proof syntax.

Hi,

I only use the little icon overlay, don't need the big menu. Would be excellent if it could be customised.

Sorry for opening issue, this should be labeled as a suggestion. I think it needs to be enabled for the github issue page on this repo.

Great mod btw.

Noted items currently do not account for items in the collection log.

For every STASH unit, show the construction level and highlight it based on the player's construction lvl.

Colour coding:

• Grey = player is not logged in
• Green = construction lvl is high enough
• Red = construction lvl is not high enough

As mentioned by @LlemonDuck, any world map markers should be removed on shutdown.

Would it be possible to add a filter for different types of clue scrolls?

I already have all the easy and medium STASH units filled, so I really don't need the indicator for those items anymore. It would be great if I could turn the indicator off for easy and medium items, but keep indicators on for Hard, Elite, and Master items.

Unless all items are owned, items with multiple variants e.g. "Dragon or Avernic defender" are not ticked off.

I just received an email from one of the plugin's users that the plugin is missing on RuneLite.

It turns out that today's RuneLite update has a few breaking changes in regard of the plugin's imports.

A discord user experienced some lag each time a new area was loaded. Perhaps this may be due to login checks in the plugin?

After switching to a speedrunning world, upon returning to normal profile, the plugin has fully forgotten which stashes have items stored in them.

the warrior guild elite clue STASH unit (black salamander) does not properly sync when using the "sync Watson board" setting.
It repeatedly marks itself as empty despite being filled.

https://i.imgur.com/v7h9MW5.gif

Sometimes, its hard to find stash units. I would like a button that allows places an arrow on the map which shows me where very stash unit is.

I have completed all my beginner and easy STASHes. I triple checked and items like white apron and iron pickaxe are definitely in my STASHes but it still shows the little easy clue dot next to them.

Happens only while playing with multiple clients

2021-10-03 15:05:33 [Client] INFO c.f.controller.FlippingPlugin - starting slot timers on login
2021-10-03 15:05:33 [Client] WARN n.runelite.client.eventbus.EventBus - Uncaught exception in event subscriber
java.lang.ArrayIndexOutOfBoundsException: Index 13 out of bounds for length 13
at com.larsvansoest.runelite.clueitems.progress.ItemTracker.writeDeltas(ItemTracker.java:62)
at com.larsvansoest.runelite.clueitems.progress.InventoryMonitor.fetchEmoteClueItemChanges(InventoryMonitor.java:74)
at com.larsvansoest.runelite.clueitems.progress.ProgressManager.processInventoryChanges(ProgressManager.java:110)
at com.larsvansoest.runelite.clueitems.EmoteClueItemsPlugin.onItemContainerChanged(EmoteClueItemsPlugin.java:188)
at net.runelite.client.eventbus.EventBus$Subscriber.invoke(EventBus.java:70)
at net.runelite.client.eventbus.EventBus.post(EventBus.java:223)
at net.runelite.client.util.DeferredEventBus.replay(DeferredEventBus.java:69)
at net.runelite.client.callback.Hooks.updateNpcs(Hooks.java:487)
at client.zh(client.java:23611)
at ev.hc(ev.java)
at client.di(client.java:7413)
at client.fz(client.java:3659)
at client.i(client.java:1893)
at at.jr(at.java:380)
at at.run(at.java:359)
at java.base/java.lang.Thread.run(Unknown Source)

I would like see my items in the costume room te be included in the collection log.

Recently, some changes to Varbit-related stuff broke the plugin. So Adam changed a few thing in his branch. I should synchronise his changes into this repository.

See Adam-/runelite-plugins@b50480e

Discord report:

Looking through the client logs it seems like I found it. I switch to my settingsMERCHANT profile, the plugin "Emote Clue Items" throw a few errors, then I see that I force close the client, open it again and it loads the same profile on startup without issue. I don't have the plugin "Emote Clue Items" activated on my settingsMERCHANT profile, but I do have it activated on my ironman's profile that I am trying to switch from. So it seems like the issue is that it crashes when trying to unload? Here is a short snippet from the log:

2023-05-26 20:59:11 CEST [pool-3-thread-1] INFO  n.r.client.config.ConfigManager - Switching profile to: settingsMERCHANT
2023-05-26 20:59:11 CEST [pool-3-thread-1] WARN  n.runelite.client.eventbus.EventBus - Uncaught exception in event subscriber
java.lang.NullPointerException: null
    at com.larsvansoest.runelite.clueitems.EmoteClueItemsPlugin.onConfigChanged(EmoteClueItemsPlugin.java:353)
    at net.runelite.client.eventbus.EventBus$Subscriber.invoke(EventBus.java:70)
    at net.runelite.client.eventbus.EventBus.post(EventBus.java:223)
    at net.runelite.client.config.ConfigManager.switchProfile(ConfigManager.java:234)
    at net.runelite.client.plugins.config.ProfilePanel.lambda$switchToProfile$7(ProfilePanel.java:666)
    at net.runelite.client.util.RunnableExceptionLogger.run(RunnableExceptionLogger.java:41)
    at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
    at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
    at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
    at java.base/java.lang.Thread.run(Unknown Source)
[16:08]
It throws multiple of the same error depending on how fast I force close Runelite. Starting up Runelite and it loading the settingMERCHANT profile after force closing it is never a issue (probably because then it doesn't have to unload the Emote Clue Items plugin?)

Thinking back on it I have noticed that very rarely it won't freeze, but that is probably because I sometimes login to another account that also don't have that plugin activated.
``` 

No longer get colored dots on items in bank or inventory after today's update.