lastcallmedia / gulp-drupal-tasks Goto Github PK

Should run PHPUnit tests. The config file and the suite should be configurable, and there should be a way to get junit output.

We should handle this just like backstop. Pull in a docker container for this sort of thing. It would be best if it's the same container we use for backstop, so we'll probably have to roll our own, or it would take forever to download 2 images for a CI build.

Maybe we should do this through a CLI flag instead of in the config file? Either way, it exists in the scaffold, but it's not configurable here.

As a user, I should be able to start a long running watch task for syntax checks.

Failures during compilation of JS will cause the build:watch or build:watch:js tasks to exit silently. The watch should continue even if compilation fails. It should show a message to indicate that the compilation has failed though.

Additionally, build:js and build should continue to output a non-zero exit code if js compilation has failed.

ESlint has a pretty awesome --fix mode that's will clean up your standards violations for you. Other static code linters offer similar tools, and it would be a nice shortcut to have this available as a one stop shop on the check* tasks. So you'd just run gulp check --fix and it would auto-fix everything it could. I think step 1 is adding this flag and wiring it up to ESLint. Then we can see what kind of crazy hoops we'll have to jump through for PHPCS.

PHPCS is slow, hard to configure, prone to failure, and generally not very nice to use.

Let's switch to something else. There's php-cs-fixer, and probably others out there.

Eslint can output junit. Check the circle.yml for how we're doing it here.

Behat fails if there's a behat.yml and you don't configure it.

Need to be able to change the PHPCS standard with configuration.