Comments (10)
FWIW, the actual bug which I intended to fix is this: LDOptions in typings.d.ts has the property evaluationExplanations whereas in index.js the respective property is called evaluationReasons:
const requestor = Requestor(baseUrl, environment, options.useReport, options.evaluationReasons, sendLDHeaders);
I assume adjusting LDOptions in typings.d.ts is the less disruptive way to fix this.
from js-client-sdk.
Thanks for catching the wrong property name. That's certainly easy to fix. We're looking into the other cross-platform issues - as you can probably guess, we've been pretty Linux-focused in our development of this project so I'm not surprised we've missed a few things like this.
from js-client-sdk.
I'm having more trouble than I expected getting the tests to run in Windows at all. If you already have a branch with the changes you've made so far, could you link to it (or just a gist of what you've got in package.json)?
from js-client-sdk.
from js-client-sdk.
Well, we would like to get the build working under Windows. But it sounds like you have had more luck so far than I've had. The environment variable issue is fairly easy to fix by changing it to use cross-env
(as some of the other commands already do), but I can't get it to the point of actually running any tests; currently it is failing for me with "Module jest-localstorage-mock in the setupFiles option was not found."
So, if you have a version of package.json that works better than that, even if the tests don't pass yet, I would appreciate a chance to see it.
from js-client-sdk.
from js-client-sdk.
Thanks. Hmm. Well, that is what I did too. My npm version is 6.4.1, maybe that makes a difference.
from js-client-sdk.
from js-client-sdk.
What I said in my last comment was that I'm not able to run the tests.
However, we did do a release yesterday which fixes the TypeScript property name error.
from js-client-sdk.
Hi. I know this is pretty late, but since your original report we've made many changes to the build, including some for Windows compatibility. We are now successfully running one of our CI builds of this repository in Windows. So if you're still interested and haven't already tried this again, I recommend trying it again.
from js-client-sdk.
Related Issues (20)
- Lighthouse audit fails with `no-unload-listeners` HOT 5
- Support running in browser extension service workers HOT 21
- Consider providing ES6 builds HOT 5
- Ublock Origin blocks some LaunchDarkly URLs HOT 6
- Event streaming in iOS standalone browser HOT 12
- Experimentation docs reference a version that is unreleased HOT 1
- client already exist error HOT 2
- Safari v12 and v13 error for package versions 3.0.0 and above HOT 3
- SDKs >= 3.0.0 no longer send click or pageview events HOT 1
- Pull only a sub set of flags for a project HOT 1
- Support passing context to the `variation` call? HOT 1
- Add opentelemetry tracing to server calls HOT 2
- Warning logged about omitting identify when client is bootstrapped HOT 4
- Unhandled Exception occurs when there is a network error HOT 5
- LD double initialisation with Strict Mode set to true.
- Bypass "do not track" setting in development environment HOT 1
- How do we retrieve the tags or custom properties using ldclient? HOT 2
- Allow to evaluate specific flags HOT 2
- option to disable logger in browser console HOT 1
- Access to XMLHttpRequest at 'https://events.launchdarkly.com/events/bulk/6374af9a71e138110cdb10cd' from origin 'https://localhost:5001' has been blocked by CORS policy: Request header field request-context is not allowed by Access-Control-Allow-Headers in preflight response. HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from js-client-sdk.