Typescript Typings about js-client-sdk

[jkodumal]

BTW, when that gets merged we will be happy to take over maintaining the typings when our library interface is updated.

[dlau]

@ISkomorokh thanks for the report. Please see this PR for an update to our typescript definitions #14 .

We will publish an update to the npm module shortly.

[IceCreamYou]

I submitted typings to DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#11916

The last typings I submitted to DefinitelyTyped were merged the next business day so I am optimistic that this issue can be closed out shortly.

That said, it would be great to have LaunchDarkly team members review the typings to confirm that they are correct and contribute changes when the library's interface changes 😀

[apucacao]

Thanks @IceCreamYou — we'll take a look shortly.

[jkodumal]

Awesome @IceCreamYou -- I added a few comments to the DT PR.

[IceCreamYou]

The PR was merged yesterday so this issue can be closed 😀

[jkodumal]

Thanks @IceCreamYou !

[ISkomorokh]

Hi guys! I'm trying to use ldclient-js in TypeScript > 2.0 project and it would be great to have working typings. At the moment, VS 2017 and VS Code are both complaining that on the import statement. The code works after build, but I can't use intellisense.

I believe this is because of namespace or no global exports or no module declaration.
https://www.typescriptlang.org/docs/handbook/modules.html#ambient-modules

package.json

"dependencies": {
...
    "ldclient-js": "^1.1.10",
  ...
},
  "peerDependencies": {},
  "devDependencies": {
...  
  "types/ldclient-js": "^1.1.2",
...
  }

Thanks!