Issue importing LDClient into Angular 5 application about js-client-sdk

[apucacao]

Hi @germs12 , sorry about that. We're looking into it. I think it is related to our recent switch to rollup.js.

[germs12]

@apucacao Thank you for the prompt response. Let me know if you'd like me to test anything. In the mean time I'll rock the LDClient.default.initalize(...) 🕺

[apucacao]

It looks like there's something going on with the default export in TypeScript specifically.

We emit ES modules (along with CommonJS and UMD modules). ./dist/ldclient.es.js does have a default export, meaning that the import in TS should just be import LDClient from 'ldclient-js'.

However, we used to do this: module.exports = { initialize, version };. From what I understand, that equates to the export default { initialize, version };, but evidently, TS doesn't think so.

I found that TS has this option available for making this work properly, in your tsconfig.json:

"allowSyntheticDefaultImports": true,

Does that allow you to avoid LDClient.default.initialize? I tried in one of our TS projects and it helped, but let me know if it works for you. 🙂

[germs12]

@apucacao Thank you again for the prompt and detailed response. I have tried out your suggestions and I have the following notes to report back.

1. It works. 🍰
2. If I change my import from import * as LDClient from 'ldclient-js' to import LDClient from 'ldclient-js', it compiles correctly but I get a TypeScript error in my editor (VSCode) saying Module ''ldclient-js'' has no default export.
3. If I only update my tsconfig.json and leave my import as import * as LDClient from 'ldclient-js' I still need to call default to make it work.

🌵