laurentpertois / mojave-compatibility-checker Goto Github PK

@laurentpertois I found that you are missing a test for the iMac Pro. You might want to add another elif statement to your if block checking for compatibility:

elif [[ "$MODELNAME" == "iMacPro" && "$MODELVERSION" -ge 1 && "$MEMORYINSTALLED" -ge "$MINIMUMRAM" && "$FREESPACE" -ge "$MINIMUMSPACE" ]]; then COMPATIBILITY="True" fi

Apple's requirements at https://support.apple.com/kb/SP777?locale=en_US state that it is Mac OS X 10.8 or later.

However, this script is still allowing 10.7.5.

First time reporting an issue on GitHub, so hopefully I am doing this correctly.

On line 87, your if statement should actually be including 14 in the major version, by using -le instead of -lt otherwise this script incorrectly reports False for overall compatibility.

if [[ "$OSVERSIONMAJOR" -ge 8 && "$OSVERSIONMAJOR" -le 14 || "$OSVERSIONMAJOR" -eq 7 && "OSVERSIONMINOR" -eq 5 ]]; then

Sure we know a Mac is compatible if it is already on 10.14, but technically the script should still report True especially if we want to use this for scoping a reinstall of macOS 10.14 for somebody that has already upgraded.