lbryio / lbry-redux

Common shared app components for desktop and mobile

lbry-redux

lbry-redux is a module which contains common React and redux code shared between lbry-desktop and lbry-android.

Installation

Add lbry-redux as a dependency to your package.json file. "lbry-redux": "lbryio/lbry-redux"

Local development

If you intend to make changes to the module and test immediately, you can use npm link to add the package to your node_modules folder. This will create a symlink to the folder where lbry-redux was cloned to.

cd lbry-redux
yarn link
cd /<path>/<to>/<project> (ex: cd ~/lbry-desktop)
yarn link lbry-redux

Build

Run $ yarn build. If the symlink does not work, just build the file and move the bundle.js file into the node_modules/ folder.

Tests

Run $ yarn test.

Contributing

We ❤️ contributions from everyone! We welcome bug reports, bug fixes and feedback on the module is always appreciated.

License

This module is released under the MIT License

lbry-redux's Issues

unify redux publish

Tracking lbry-redux publish integration goals and progress

• desktop uses publish
• android uses publish
• supports generic asset upload (thumb, cover)
• supports channel edits
• handles edits
• handles post publish clear and navigation
• separates actual form parameter values from helper values

issues: local app settings reducer settings, e.g. osNotificationsEnabled, etc.

Not all messages are marked for localization.

While using the app, I noticed that most of the toasts are localized. When I searched the repo, I see that some entries are marked with __( ) , while most aren't.

I can help out with this, assuming that the fix is simply to:

1. Encapsulate all the messages with __( ).
2. Add the strings (if not already) into lbry-desktop and lbry-mobile.

Add precommit script to build module with each commit

@seanyesmunt and @akinwale discussed this as a method to ensure code is not injected when modules are built locally and committed to github.

Calling wallet sync after channel creation

After channel creation, we should call wallet sync to make sure the new certificate is synced.

Use preference_set/get to store user state and share across apps

Support i18n (stub)

This ticket needs to be fleshed out before beginning work

Add wallet encryption support (selectors, actions, and reducers)

The Issue

Per lbryio/lbry-desktop#762 and lbryio/lbry-desktop#1097, wallet encryption support (selectors, actions, and reducers) needs to be added

System Configuration

• LBRY Daemon version:
• LBRY App version:
• LBRY Installation ID:
• Operating system:

Anything Else

Screenshots

Add error when display type not passed to doNotify

The Issue

Per comments in lbryio/lbry-desktop#1493 (comment), we should add an error when the doNotify function does not contain all required parameters. If we don't, the notifications get queued up and other notifications don't show afterwards.

System Configuration

• LBRY Daemon version:
• LBRY App version:
• LBRY Installation ID:
• Operating system:

Anything Else

Screenshots

support new SDK pagination changes

See https://github.com/lbryio/lbry-sdk/releases/tag/v0.44.0 . There will be a patch to fix 2 other bugs founds recently, so don't upgrade to this one yet.

breaking API change for all list commands which now all always paginate - for simple upgrade in client code without implementing pagination logic use page: 1 page_size: 1000 or similar and just extract the list in items

`flow` is problematic on Windows, caused by `flow-babel-webpack-plugin` (deprecated/archived)

May be related to zhirzh/flow-babel-webpack-plugin/issues/5

Findings:

• [email protected] works great with flow-webpack-plugin
• flow-bin versions 0.70.0+ appear to re-introduce issues as previously reported. See facebook/flow/issues/3528 and facebook/flow/issues/5870

I'll likely add these changes in with /pull/59 since I've switched back to a Window dev machine for the time being.

Update APIs for SDK 0.43 and wallet sync

Fix lbry tv + redux issues around fs

It complained about the import fs, which I just removed for now in a hotfix. We probably need app vs web checking like we do on desktop, or some config in the rollup.

May be relevant webpack-contrib/css-loader#447

rollup/rollup#897

Support for Full Unicode URLs

See https://github.com/lbryio/internal-issues/issues/216

deleting default wallet before syncing

If we are sure a user is in first-run mode, have an empty wallet, and are signing into a synced account, we should delete the default account before syncing. IThis should be the case every time for Android.

f we don't every time they sign-in on a new device will result in an additional blank account being synced. This means an additional 26 wallet addresses need to be subscribed to.

make parseURI (URL) support all possible lbry urls

Currently, parseURL errors on the following because it doesn't expect modifiers after /
'lbry://@channel#2/stream:5'
'lbry://@channel$2/stream#5'

CORS Error when canceling publish on Odysee / LBRY

lbry-redux/src/redux/actions/publish.js

Line 19 in c31161c

export const doResetThumbnailStatus = () => (dispatch: Dispatch) => {

This function causes a CORS error client side:

https://spee.ch/api/config/site/publishing 302 redirections to -> https://lbry2.vanwanet.com/speech/api/config/site/publishing

The redirection on spee.ch has proper CORS, however the location at lbry2.vanwanet.com does not have any CORs set.

@tzarebczan suggested removing the check entirely.

Cannot load pages such as lbry://anonymous-liam

Steps to Reproduce:

1. Git pull latest master on lbry-redux and lbry-desktop.
2. Search anonymous-liam.
3. Click.
4. Crash.

tags

Allow to add more tags, so people can specify better.
Suggest existing tags when typing for a tag, so videos will be more specified under same tags

'/wallet' as a link target should not be localized

There are two of these entries in redux:

linkTarget: __('/wallet'),

If it's a link, it should not be localized, right?
Currently, this string also exists in Transifex for desktop -- I'm not sure if it will mess things up if a translator changes translates it.

Remove all api.lbry.io references

lbry-redux/src/lbryapi.js

Lines 9 to 11 in 76d8bbe

	const CONNECTION_STRING = process.env.LBRY_APP_API_URL
	? process.env.LBRY_APP_API_URL.replace(/\/*$/, '/') // exactly one slash at the end
	: 'https://api.lbry.io/';

This repo should be using the lbryinc repo to connect to the apis.

https://github.com/lbryio/lbryinc/blob/f590ddc077bf6e3e8fcc64820ba94a193525d911/src/lbryio.js#L11-L14

A few problems with this:

• Because of environment variables in node modules not working, the following has to be leveraged. The only way to set the url is to modify bundle files.

https://github.com/lbryio/lbryinc/blob/f590ddc077bf6e3e8fcc64820ba94a193525d911/src/lbryio.js#L11-L14

• Because it is using this old api library it does not send the auth token. I need the list_homepage api to receive a token for my discovery changes I am testing.

As a result this is a blocker for me. I spoke with @seanyesmunt and this was just an oversight that it was not moved before. He is going to move them over asap.