ldd / fantasy-map-generator Goto Github PK

As shown here, and mentioned in the reddit thread

an SVG feGaussianBlur effect could eventually be added to the demo

I'm a canvas noob - could you add an example to the readme showing how to create an SVG element that I could pass in to drawMap?

I tried just tossing <svg id="map"></svg> into my body, but passing the element in to drawMap resulted in

Uncaught TypeError: svg.selectAll is not a function
    at drawPaths (view.js:126)
    at Object.drawMap (visualize.js:20)
    at (index):16

which I'm pretty sure is the result of me not knowing what I'm doing.

If I import the web build in Chrome 56, terrain.min.js throws an error:

Uncaught ReferenceError: Invalid left-hand side expression in postfix operation

If I comment out the webpack.optimize.UglifyJsPlugin instantiation in webpack.web.config.js, then terrain.min.js doesn't throw any errors.

typing 2^10 should be an acceptable input for the number of points in the demo, make a map with 1024 points.

See #1. Even if a fix is provided, uglify should be optional.
In order to fix this, I'll probably use a webpack env variable.

Right now npm contains the node build (main.js) but not the web or web worker builds of the module. Are you assuming this module will be bundler-only? If so, you could drop the webpack scripts for the other builds to simplify things.

the README.md should have a link to the demo.