ldesignmedia / moodle-availability_ipaddress Goto Github PK

Hi, not really an issue but was wondering would it be possible to have something that restricted a whole course by IP?

Thanks

Good day,

The database field used by this plugin to store ip addresses is character varying(255).

This places a hard limit on the number of addresses that can be provided.

Full enumeration is useful, as subnets can include hosts that you don't intend for test use.

By the way I am happy to look into this issue and resolve it, but will need a little time.

Liam

The plugin uses address_in_subnet function for checking the ips. However the validation does not accept an IP range (x.x.x.x-y) which is very useful for controlling the access for small-medium classrooms.

Moodle provides the library /lib/classes/ip_utils.php that offers the following convenient functions for checking addresses:

• is_ip_address($address)
• is_ipv4_range($addressrange)
• is_ipv6_range($addressrange)

Please excuse me for not contributing with a tested pull request, but I'm currently without a dev environment for some time.

I propose that the function is_valid_ipaddresses() be implemented as:

public static function is_valid_ipaddresses($ipaddresses) : bool {
       $ipaddresses = implode(',', $ipaddresses);
       foreach ($ipaddresses as $ipaddress) {
           if ( is_ip_address($ipaddress) === false &&
                is_ipv4_range($ipaddress) === false &&
                is_ipv6_range($ipaddress) === false  ) {
               return false;
           }
       }

       return true;

   }

I hope this will help making this plugin more useful.

Greetings.

IP validation seems too permissive I was able to submit following value.

Moodle now implements a new privacy api - it would be nice if you could implement this in your plugin.

Sites that use continuous integration processes will not be able to use your plugin as Moodle now includes unit tests to check that all installed plugins contain appropriate privacy classes.

more information on the privacy api is here:
https://docs.moodle.org/dev/Privacy_API

please note - this is not a blocker for approval in the plugins db but would be nice to add at some point.

When you select the condition to restrict to ip's that differs from a specific one, it doesn't work. Its only behaviour is to SHOW the content to the select ip/ip range.

All my external connections to moodle come from the firewall IP, i need to block this specific IP