learn-co-curriculum / react-hooks-component-props-mini-project Goto Github PK

Canvas Link

https://learning.flatironschool.com/courses/6273/assignments/232346?module_item_id=544471

Concern

These lines in package.json are the incorrect syntax and cause the test not to run .

"jest": {
"transform": {
"^.+\.js$": "babel-jest",
"^.+\.svg$": "jest-svg-transformer"
}
},

Additional Context

Instructor Antonio is DOPE

Suggested Changes

removing the above lines causes the test to run properly.

Canvas Link

https://learning.flatironschool.com/courses/6383/assignments/235196?module_item_id=551844

Concern

In the instructions for ArticleList, it is stated that the props passed down to ArticleList will be post (singular): an array of Article components (one component for each post passed down as a prop called post to ArticleList).

However, the tests for this lab make clear that ArticleTest will be tested with a prop called posts (plural):

test("renders a <main> element", () => {
  const { container } = render(<ArticleList posts={posts} />);
  expect(container.querySelector("main")).toBeInTheDocument();
});

Given that the prop is an array, the plural form makes more sense, and I think it would be clearer if it were referred to as such in the instructions.

Additional Context

I paired with a Technical Coach who agreed that this seemed like a typo in the instructions, and suggested I flag the issue here.

Suggested Changes

Just a typo change--changing "post" to "posts" in the instructions would suffice, I think!

Canvas Link

https://learning.flatironschool.com/courses/5842/assignments/214265

Concern

In the deliverables, the expected name of the prop is italicized but I think it should be made more clear that they need to name the props correctly or they will not pass the tests. For example, change the first deliverable from
an <h1> with the _name_ of the blog, passed as a prop to
an <h1> with the name of the blog, passed as a prop called name

It is currently not clear enough and the error messages that are returned from learn test when their code works but they're just naming their props incorrectly is not helpful to the student. I.E.: I changed the prop name "posts" to "articles" (Which I have seen multiple students do) but this is the error they get from learn test:

This is confusing for students because their articles are rendering just fine but the test is not passing. It is difficult for students to look at this error and understand that they just need to rename articles to posts to get their tests passing.

Additional Context

Since codegrade will require all tests to pass before they can submit the assignment, I highly recommend making this change before phase two when codegrade is live with students.

Suggested Changes

No response

Canvas Link

https://learning.flatironschool.com/courses/5285/assignments/172447?module_item_id=376309

Concern

The following should be revised for this lesson:
'Article' and 'ArticleList' components should be renamed to 'Post' and 'PostList'.

This is because this is a blog website with posts, and not academic articles. The context with the naming is weird, and would be easier if this was just renamed accordingly.

Additional Context

No response

Suggested Changes

Mentioned above ^