leddt / visualstudio-colors-solarized Goto Github PK

Line numbering color is wrong, it's blue while it should be Base0 or Base1, I'm not sure. This is true for both settings file. (I use WDExpress, and the color used to be fine in VS2010)

The (light) theme, as generated by the template in this repo, makes heavy use of bold fonts, and very few colors.

I have enhanced the syntax highlighting in my fork, at least for C# so far. See my branch @ https://github.com/mario-d-s/visualstudio-colors-solarized/tree/syntax-coloring

I whipped up an example file containing all significant elements and took screenshots for comparison.

Default coloring

• Most elements use the color yellow
• String literals and integer literals have the same color
• Error and warning squiggles are hard to distinguish
• Bold font usage is distracting and makes code "expand" visually as the parser matches tokens

My version

• Reduced usage of bold fonts, reserved to distinguish between different elements with the same color, e.g. string literal vs. verbatim string literal.
• As string literals should be used judiciously, they have been made orange to make them stand out more.
• Classes, interfaces, value-types (structs), enums and delegates all have different colors. This makes me a lot more productive as I don't have to use intellisense or mouse-hover tooltips to determine what stuff is what.
• Changed error/warning squiggles from red/orange to red/yellow

I would like to open a PR, but I realize this may well be an entirely personal preference and not everyone may want their C# to look like a coloring book. Hence, I open this issue to have a discussion first.

@leddt Is enhancing the syntax highlighting something you want to integrate in your repo? If so, do you agree with my choices for colors or do you want some changes?

If this is something you'd like, I'll also point out there is more work to be done here to enhance other languages and contexts (F#, XML, ASPX, XAML, ....)

It seems that the URL Hyperlink colour is the default bright blue, rather than a blue from Solarized.

When selecting text the selection colour makes any comments unreadable, not a major issue, but I think it doesn't look right when you're selecting text.

An example http://cl.ly/0L2l0x0f1O3C2C2I233w

When exporting Fonts and Colors settings from Visual Studio Professional 2017, version 15.6.5, I get the following Category GUIDs in the .vssettings file:

• F9D6BCE6-C669-41DB-8EE7-DD953828685B
• E0187991-B458-4F7E-8CA9-42C9A573B56C
• 58E96763-1D3B-4E05-B6BA-FF7115FD0B7B
• FF349800-EA43-46C1-8C98-878E78F46501
• 75A05685-00A8-4DED-BAE5-E7A50BFA929A
• FA937F7B-C0D2-46B8-9F10-A7A92642B384
• B36B0228-DBAD-4DB0-B9C7-2AD3E572010F

In SettingsTemplate.xml are the following:

• A27B4E24-A735-4D1D-B8E7-9716E1E3D8E0
• 75A05685-00A8-4DED-BAE5-E7A50BFA929A
• F9D6BCE6-C669-41DB-8EE7-DD953828685B

I'm trying to derive their meanings from the properties within, but I've already spotted clear discrepancies between the template and my own export.

@leddt Can you please share what you have found out about them so far?

Why it is highlighting a jQuery Id selector like this?

I originally tried a couple different things to get the pallete to work. Once you select the vssettings file, it will just close the box and do nothing... I dug into the file and ripped out the Nuget category and it ended up working perfectly right after...

This was true for both 2010/2012... Im currently on the latest 2.1 nuget...

So, the issue is, once you rip the nuget section out, it works... leave it in, it doesnt work...

thanks! theme looks great regardless...

Up to VS2010 the green was correct with 0x00009985, but with the start of using the generator script, green is now 0x00079A71. Very nearly the same color but the original has slight better contrast next to cyan.

There should be a single script to run that would update the vssettings for every VS version.

Each version would still have it's own template file.

I've cloned the repo and when I try to import either dark or light file into vs2017 I get this:

The settings in file 'C:\VSS\src\Customer\TKM\solarized-dark.vssettings' cannot be imported because this file is not a valid .vssettings file.

vs 14.0.25431.01 Update 3

As in the following image, the blue used for the name attribute in xsl files is awkward to read:

Your styles here seem to be an older version: https://studiostyl.es/users/1833

I've found that using copying the raw URL link and pasting it into Visual Studio 2012 Premium doesn't work on Windows 8 x64. This appears to be a bug in Visual Studio because the dialog just closes, with no action having taken place.

I suggest adding a note or something to indicate you must download it and then import the downloaded file

I noticed my Visual Studio 2017 was listing User Types - Structures and User Types - Type Parameters without custom colors, so I checked with the template and it didn't have those in the list next to the other user types.

According to the ReSharper settings also (needlessly in 2017?) having those, Structures should use foreground $Yellow and Type Parameters should use $Magenta. Or in .settings XML:

<Item Name="type parameter name" Foreground="0x008236D3" Background="0x02000000" BoldFont="No" />
<Item Name="struct name" Foreground="0x000089B5" Background="0x02000000" BoldFont="No" />

I also note how my Visual Studio 2017 writes out its .settings using different item names. I'm not sure what's up with that. Maybe Visual Studio 2017 is backwards compatible with different 2015 names or something? For example, upon exporting, I don't see "User Types - Classes" as in the template used here and what I have successfully imported, but I do get "class name".

The Solar light theme file is not valid.

Visual Studio complaints and does not apply the configurations. No error message (at least specifically) is outputed.

I've been trying to dig around, but I can't figure out how the Razor View Engine syntax displays a different background from the rest of the HTML markup. It is a horrible light gray background, almost unreadable.

Edit: There's an actual Razor Code option under Text Editor. I set the background to Hue: 131, Sat 74, Lum: 57 Red: 41, Green: 69, Blue: 80 ... much better but I don't know if there's a more rigid way to pick background colors to conform to solarized specs.

Importing the settings into the preview version of visual studio 2019 doesn't seem to have any effect.

It's almost unreadable if you enable "Highlight Current line"
I use "Productivity Power Tools" to highlight the current line...

As a result of this, if you import the solarized dark settings while you have the theme set to "light" or "blue" they are black on the dark-blue background and very hard to read. If you set it to the dark theme before importing they'll be white, which is OK.

Color setting does not work in C++, C++/CLI for VS2012.

It is need to set additional 'C++ xxx' items in 'Tool -> Options -> Fonts and Colors' to work properly.

I attached my exported dark color setting that has Cpp* items:

                        <Item Name="CppMacroSemanticTokenFormat" Foreground="0x00969483" Background="0x01000001" BoldFont="Yes"/>
                        <Item Name="CppEnumSemanticTokenFormat" Foreground="0x00C4716C" Background="0x01000001" BoldFont="Yes"/>
                        <Item Name="CppLocalVariableSemanticTokenFormat" Foreground="0x00969483" Background="0x01000001" BoldFont="No"/>
                        <Item Name="CppParameterSemanticTokenFormat" Foreground="0x00969483" Background="0x01000001" BoldFont="No"/>
                        <Item Name="CppTypeSemanticTokenFormat" Foreground="0x000089B5" Background="0x01000001" BoldFont="Yes"/>
                        <Item Name="CppRefTypeSemanticTokenFormat" Foreground="0x000089B5" Background="0x01000001" BoldFont="Yes"/>
                        <Item Name="CppValueTypeSemanticTokenFormat" Foreground="0x00008983" Background="0x01000001" BoldFont="Yes"/>
                        <Item Name="CppFunctionSemanticTokenFormat" Foreground="0x00969483" Background="0x01000001" BoldFont="No"/>
                        <Item Name="CppMemberFunctionSemanticTokenFormat" Foreground="0x00969483" Background="0x01000001" BoldFont="No"/>
                        <Item Name="CppMemberFieldSemanticTokenFormat" Foreground="0x00969483" Background="0x01000001" BoldFont="No"/>
                        <Item Name="CppStaticMemberFunctionSemanticTokenFormat" Foreground="0x00969483" Background="0x01000001" BoldFont="No"/>
                        <Item Name="CppStaticMemberFieldSemanticTokenFormat" Foreground="0x00969483" Background="0x01000001" BoldFont="No"/>
                        <Item Name="CppPropertySemanticTokenFormat" Foreground="0x00969483" Background="0x01000001" BoldFont="No"/>
                        <Item Name="CppEventSemanticTokenFormat" Foreground="0x00C4716C" Background="0x01000001" BoldFont="Yes"/>
                        <Item Name="CppClassTemplateSemanticTokenFormat" Foreground="0x000089B5" Background="0x00362B00" BoldFont="Yes"/>
                        <Item Name="CppGenericTypeSemanticTokenFormat" Foreground="0x00AF912B" Background="0x01000001" BoldFont="Yes"/>
                        <Item Name="CppFunctionTemplateSemanticTokenFormat" Foreground="0x00969483" Background="0x01000001" BoldFont="No"/>
                        <Item Name="CppNamespaceSemanticTokenFormat" Foreground="0x00969483" Background="0x01000001" BoldFont="No"/>
                        <Item Name="CppLabelSemanticTokenFormat" Foreground="0x00969483" Background="0x01000001" BoldFont="No"/>

Running Visual Studio Enterprise 2017 version 15.7.1

Importing the vssetings files gives the following error:
"The settings in file C:\Users...\solarized-dark.vssettings" cannot be imported because this file is not a valid .vssettings fil."

Visual Studio does not provide any debugging information.