Support for eth_getEncryptionPublicKey and eth_decrypt (EIP-1024) about app-ethereum

[pepawel]

Skiff requires this, so +1

[firnprotocol]

@pepawel saw your edits.

right, the problem is that when you call eth_getEncryptionPublicKey with a Ledger logged in, MetaMask throws:

{
    code: -32603
    message: "Ledger does not support eth_getEncryptionPublicKey."
    ...
}

this is because of this pull request, which essentially defined this error behavior—under the assumption that Ledger doesn't support it.

Now that Ledger does support this (see above), I think MetaMask needs to re-visit this error behavior and disable it. that's my read. i haven't gotten a response from them yet though.

[colinnielsen]

Any thoughts from Ledger on this? It would be great if this was implemented

Hello, thank you for this idea, it is currently not in our roadmap but we could take a look at it, probably beginning of next year.

While we are discussing Tornado.cash, feel free to have a look at https://torn.community/t/tornado-cash-in-ledger-live/1735 this would definitely help pushing these topics.

Thank you,
Adrien

[lksdfkj3298sKL]

Any updates on this?

[lksdfkj3298sKL]

I'm building an app that needs encryption/decryption support for messages. Currently only supports MetaMask. Would be great for ledger support as well.

[iknowdavid]

I'll plus one this issue too unfortunately: 401884

[firnprotocol]

bumping this; would be great to see this feature. any updates by any chance?

[cseguret-ledger]

Resolves #240

[firnprotocol]

are you saying that this issue is now resolved? is the fix live in ledger? (do i need to update ledger live? or...)

[pepawel]

@firnprotocol I'm not in a dev team, however I upgraded my Ledger's firmware today and can confirm Skiff works. It probably means the issue is resolved.

EDIT: The problem with Skiff is still there with current Ledge's firmware and updated Ethereum app. I'm sorry I haven't checked this deeply enough before. Currently Skiff offers 1) assigning wallet to email address and 2) logging in using wallet. I tried the first successfully and assumed the second works. It does not.

I don't know exactly what the source of the problem with Skiff and/or Ledger is now, but the fact is I still can't login to Skiff using Metamask with Ledger, while I'm able to login using Metamask itself.

[firnprotocol]

@pepawel excellent, thanks for the heads-up—though it looks like now MetaMask needs to update itself to not throw an error in this case? (see lined issue above)

[pepawel]

@firnprotocol thank you for explaining the issue, it definitely makes sense!