Regressions in 3.2.0 (vs 2.4.4) about slop

[leejarvis]

Argument arrays can no longer contain nil values.

I'm not sure I follow this one. Could you provide an example? I don't see how Argument arrays would ever contain nil values.

Ranges can no-longer have negative argument values.

This is an oversight on my part. I'll add it later today.

:as => :count doesn't work anymore.

Added in the above commit. Thanks for reporting, I'll close this issue once these issues are all resolved.

[leejarvis]

I can't reproduce the Range negative argument value issue. See the following code:

opts = Slop.new do
  on :c, :case, argument: true, as: Range
end

opts.parse
p opts.to_hash
#=> {:case=>-1..10}

Also see https://github.com/injekt/slop/blob/master/test/option_test.rb#L78

[ConradIrwin]

Ok, it turns out the range problem only happens when there's an optional argument:

s = Slop.new{ |opt| opt.on :foo, :f, :as => Range, :optional_argument => true }
s.parse! %w"--foo -1"
# => ["-1"]

The nil's happens because of this:

argstring = "amend-line --help"
argstring =~ /^amend-line\s*(!)?/=> 0
as = Regexp.last_match.to_a.drop(1) + Regexp.last_match.post_match.split(" ")
# => [nil, "--help"]
Slop.new{ |opt| opt.help }.parse!(as)
# NoMethodError: undefined method `start_with?' for nil:NilClass
# from /Users/cirwin/.rvm/gems/ruby-1.9.3-p125@pry/gems/slop-3.2.0/lib/slop.rb:418:in `process_item'

Because the previous version of slop just worked in this regard, I don't think we even noticed how disgusting it was. Now I think about it more, it may be possible to avoid doing this at Pry's end; in case you don't want to allow that :).

[leejarvis]

Slop just expects the input Array to include String only values. Ignoring nil values is something I'm prepared to add, though, and have done in the latest commit. Fixing the other issue now

[leejarvis]

@ConradIrwin Could you confirm your issues are resolved before I push a new gem? Thanks again for reporting.

[ConradIrwin]

Hi @injekt, thanks for the phenomenal response!

The only remaining issue is the one I alluded to above about the counting being broken:

Slop.new{ |opt| opt.on :v, :verbose, :as => :count }.tap{ |o| o.parse!(%w(-vvv))}.to_hash
# => {:verbose=>1}

[leejarvis]

Hi @ConradIrwin,

You're welcome. Please check the latest commit and run Pry against Slop HEAD to ensure there's no more regression. Once you're happy let me know and I'll push a gem up.

[ConradIrwin]

Thanks. All our tests pass again now :).

[leejarvis]

Great. I've bumped the version to 3.3.0 to make it a little easier for Pry to manage http://rubygems.org/gems/slop/versions/3.3.0